452080 - Display navigation screen when the URL bar is activated

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Madhava Enros [:madhava]]

Fennec behaviour should be as described here:

https://wiki.mozilla.org/Mobile/UI/Designs/TouchScreen/workingUI#Navigation_to_a_new_page

At the moment (M7), the URL bar activates (gets a cursor) when tapped, and awesomebar results appear when the user begins to type, but pre-typing awesomebar listings are not shown, and no search buttons are displayed.

Comment 1

[Stuart Parmenter]

neil, can you take a look at this please?

Comment 2

[Neil Deakin]

Currently, the existing url is displayed when the url field is focused. Is the idea here to

1. clear the url field and display the 'default' history results whenever it is focused
2. show history results that match the current url, or
3. leave the field at its current value, show 'default' history and then change the results when editing the field?

Search buttons would be displayed if the search components were built (that's bug 444735). The UI for that is already implemented, although running it in a current build, the hourglass icon appears in the wrong place which should be an easy fix.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I think #3 is the idea.

Comment 4

[Neil Deakin]

Attachment: polish search buttons and autocomplete, work in progress

- show only the first four search engines
- display default autocomplete on click and when there are no results

There is some flicker as the results switch between matches and the default.

Comment 5

[Neil Deakin]

Attachment: change to autocomplete.xml to eliminate flickering

This patch changes the height calculation so that if the popup has a height attribute explicitly set, the height is not adjusted.

Comment 6

[Neil Deakin]

Attachment: updated autocomplete and search patch

The other toolkit patch makes this flicker less when typing when there are no matches. The search service change in bug 444735 is needed for the search buttons to appear.

Comment 7

[Neil Deakin]

Comment on attachment 337883 [details] [diff] [review]
change to autocomplete.xml to eliminate flickering

Not sure how to test this.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 337884 [details] [diff] [review]
updated autocomplete and search patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
>-  openDefaultHistory : function () {
>-    if (!this._edit.value) {
>-      this._autocompleteNavbuttons.hidden = true;

Looks like you remove any need for _autocompleteNavbuttons with this patch. You could remove the other occurrences where we init the value.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 337884 [details] [diff] [review]
updated autocomplete and search patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+      container.appendChild(button, container.firstChild);

appendChild only takes one argument :)

>-      this._edit.focus();
>+      // nasty way to focus the edit field
>+      document.commandDispatcher.advanceFocusIntoSubtree(document.getElementById("urlbar-container"));

Why is this needed?

Comment 10

[Neil Deakin]

> >+      // nasty way to focus the edit field
> >+      document.commandDispatcher.advanceFocusIntoSubtree(document.getElementById("urlbar-container"));
> 
> Why is this needed?

Actually, I realize we can just use:

this._edit.inputField.focus()

I will make these changes.

Comment 11

[Neil Deakin]

Attachment: another updated autocomplete and search patch

Comment 12

[Stuart Parmenter]

is this ready to land?

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

verified in beta3