Display navigation screen when the URL bar is activated

VERIFIED FIXED in fennec1.0a1

Status

defect
P2
normal
VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: madhava, Assigned: enndeakin)

Tracking

Trunk
fennec1.0a1
Bug Flags:
wanted-fennec1.0 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: UI polish)

Attachments

(3 attachments, 1 obsolete attachment)

Fennec behaviour should be as described here:

https://wiki.mozilla.org/Mobile/UI/Designs/TouchScreen/workingUI#Navigation_to_a_new_page

At the moment (M7), the URL bar activates (gets a cursor) when tapped, and awesomebar results appear when the user begins to type, but pre-typing awesomebar listings are not shown, and no search buttons are displayed.
Whiteboard: UI polish
Assignee: nobody → mark.finkle
Flags: wanted-fennec1.0+
Priority: -- → P2
Assignee: mark.finkle → enndeakin
neil, can you take a look at this please?
Currently, the existing url is displayed when the url field is focused. Is the idea here to

1. clear the url field and display the 'default' history results whenever it is focused
2. show history results that match the current url, or
3. leave the field at its current value, show 'default' history and then change the results when editing the field?

Search buttons would be displayed if the search components were built (that's bug 444735). The UI for that is already implemented, although running it in a current build, the hourglass icon appears in the wrong place which should be an easy fix.
I think #3 is the idea.
- show only the first four search engines
- display default autocomplete on click and when there are no results

There is some flicker as the results switch between matches and the default.
This patch changes the height calculation so that if the popup has a height attribute explicitly set, the height is not adjusted.
The other toolkit patch makes this flicker less when typing when there are no matches. The search service change in bug 444735 is needed for the search buttons to appear.
Attachment #337718 - Attachment is obsolete: true
Attachment #337884 - Flags: review?(mark.finkle)
Comment on attachment 337883 [details] [diff] [review]
change to autocomplete.xml to eliminate flickering

Not sure how to test this.
Attachment #337883 - Flags: review?(gavin.sharp)
Comment on attachment 337884 [details] [diff] [review]
updated autocomplete and search patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
>-  openDefaultHistory : function () {
>-    if (!this._edit.value) {
>-      this._autocompleteNavbuttons.hidden = true;

Looks like you remove any need for _autocompleteNavbuttons with this patch. You could remove the other occurrences where we init the value.
Attachment #337884 - Flags: review?(mark.finkle) → review+
Attachment #337883 - Flags: review?(gavin.sharp) → review+
Comment on attachment 337884 [details] [diff] [review]
updated autocomplete and search patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+      container.appendChild(button, container.firstChild);

appendChild only takes one argument :)

>-      this._edit.focus();
>+      // nasty way to focus the edit field
>+      document.commandDispatcher.advanceFocusIntoSubtree(document.getElementById("urlbar-container"));

Why is this needed?
> >+      // nasty way to focus the edit field
> >+      document.commandDispatcher.advanceFocusIntoSubtree(document.getElementById("urlbar-container"));
> 
> Why is this needed?

Actually, I realize we can just use:

this._edit.inputField.focus()

I will make these changes.
is this ready to land?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified in beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.