452087 - nsProfileLock::Lock sets mHaveLock on some failures

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Profile: BackEnd, defect)

Description

[William Bardwell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 

In nsProfileLock::Lock it sets mHaveLock in a couple of failure cases for OSX and unix.  Basically at the end of the code that locks stuff rv is set to the result from LockWithSymlink(), but that is never checked before setting mHaveLock to PR_TRUE.  Presumably there should be a check and return that avoids that.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Benjamin Smedberg]

This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE.

If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.