Closed
Bug 452118
Opened 16 years ago
Closed 16 years ago
remove nsIMouseListener interface
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
19.57 KB,
patch
|
smaug
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
nsIMouseListener doesn't seem to be used for anything. Takes up memory since there is an instance pointer in nsBaseWidget and adds clutter to widget code.
Attachment #335413 -
Flags: review?(Olli.Pettay)
Comment 2•16 years ago
|
||
Comment on attachment 335413 [details] [diff] [review] fix v1.0 I think we can do this. Can't find anyone using the interface, which was added there 1998.
Attachment #335413 -
Flags: review?(Olli.Pettay) → review+
Comment 3•16 years ago
|
||
Or is it possible that some plugin uses the interface?
Attachment #335413 -
Flags: superreview?(roc)
I tested the popular Mac OS X plugins and they seem to work fine with this patch. I highly doubt any plugins on any platforms use this. Plugin vendors tend to go for tapping into the native event system directly when they are dissatisfied with events they get via NPAPI. We'd probably find out really quickly if plugins did need this but I really doubt it.
Comment on attachment 335413 [details] [diff] [review] fix v1.0 nice
Attachment #335413 -
Flags: superreview?(roc) → superreview+
landed on trunk
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•