Closed Bug 452126 Opened 16 years ago Closed 2 years ago

nsExternalAppHandler::OnStartRequest doesn't check if mDialog->Show failed

Categories

(Firefox :: File Handling, defect)

Product:
Firefox
Component:
File Handling
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: WeirdAl, Unassigned)

References

(
URL
)

Details

At Skyfire, we have the helper dialog throw an exception (deliberately).  We also suppress opening new tabs.  Unfortunately, these two circumstances combine, when a new tab opens to download something, to close the Firefox window we rely on.

I'm filing this bug about the failure to check rv - though the window closing underneath us may be a different bug.  (Found on Mozilla 1.8 code, but the code hasn't changed in 1.9.1 trunk.)
Product: Core → Firefox
Version: Trunk → unspecified

Is this bug still relevant or can it be closed by now?

Flags: needinfo?(ajvincent)

I think we can close it.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(ajvincent)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.