nsExternalAppHandler::OnStartRequest doesn't check if mDialog->Show failed

NEW
Unassigned

Status

()

11 years ago
3 years ago

People

(Reporter: WeirdAl, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

11 years ago
At Skyfire, we have the helper dialog throw an exception (deliberately).  We also suppress opening new tabs.  Unfortunately, these two circumstances combine, when a new tab opens to download something, to close the Firefox window we rely on.

I'm filing this bug about the failure to check rv - though the window closing underneath us may be a different bug.  (Found on Mozilla 1.8 code, but the code hasn't changed in 1.9.1 trunk.)

Updated

3 years ago
Component: File Handling → File Handling
Product: Core → Firefox
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.