Closed
Bug 452135
Opened 16 years ago
Closed 16 years ago
nsBadCertHandler.js should be in packages-static
Categories
(Firefox Build System :: General, defect, P1)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1
People
(Reporter: mozbugs, Assigned: mozbugs)
References
Details
(Keywords: fixed1.9.0.2, fixed1.9.1)
Attachments
(3 files, 1 obsolete file)
1.46 KB,
patch
|
Gavin
:
review+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
676 bytes,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
Details | Diff | Splinter Review |
Bug #383430 added this for part of its functionality, so it needs to be distributed as well.
Flags: blocking1.9.0.2?
Attachment #335429 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•16 years ago
|
Flags: blocking-firefox3.1?
Updated•16 years ago
|
Attachment #335429 -
Flags: review?(gavin.sharp) → review+
Comment 1•16 years ago
|
||
Other apps will want this as well, you should patch their packages-static (or equivalents) as well.
Assignee | ||
Comment 2•16 years ago
|
||
Comment on attachment 335429 [details] [diff] [review] Add nsBadCertHandler.js to packages static [Checkin: Comment 14] Requesting a1.9.0.2?. Patch applies to Firefox 3.0.x branch as well.
Attachment #335429 -
Flags: approval1.9.0.2?
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 3•16 years ago
|
||
(In reply to comment #1) > Other apps will want this as well, you should patch their packages-static (or > equivalents) as well. I fixed that in bug 451740 for SeaMonkey.
Assignee | ||
Comment 4•16 years ago
|
||
Is comm-central the only other place where there are Gecko 1.9.x based apps?
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #3) > (In reply to comment #1) > > Other apps will want this as well, you should patch their packages-static (or > > equivalents) as well. > > I fixed that in bug 451740 for SeaMonkey. Oops. New patch just for thunderbird coming up.
Assignee | ||
Comment 6•16 years ago
|
||
OOC, why doesn't thunderbird have a unix packages-static?
Attachment #335467 -
Attachment is obsolete: true
Attachment #335468 -
Flags: review?(gavin.sharp)
Attachment #335467 -
Flags: review?(gavin.sharp)
Comment 7•16 years ago
|
||
Comment on attachment 335468 [details] [diff] [review] Add to thunderbird's packages [Checkin: Comment 8] Mostly, Tb/Linux doesn't have one because the closest anyone has ever come to offering a persuasive reason to have one is "maybe it would slightly increase the odds that a Linux-using dev would |make package| and realize that they forgot to add something." But despite the fact that I think that was *my* reason, I've never seen any real evidence that Fx's is providing that benefit :)
Attachment #335468 -
Flags: review?(gavin.sharp) → review+
Comment 8•16 years ago
|
||
Comment on attachment 335468 [details] [diff] [review] Add to thunderbird's packages [Checkin: Comment 8] http://hg.mozilla.org/comm-central/index.cgi/rev/1c152d460854
Attachment #335468 -
Attachment description: Add to thunderbird's packages → [checked in] Add to thunderbird's packages
Comment 9•16 years ago
|
||
(In reply to comment #4) > Is comm-central the only other place where there are Gecko 1.9.x based apps? Calendar (Sunbird & Lightning) is still on the cvs trunk. If you patch the packages-static there as well, that would be great.
Updated•16 years ago
|
Depends on: 451740
Flags: blocking-firefox3.1?
Product: Firefox → Core
QA Contact: build.config → build-config
Target Milestone: Firefox 3 → ---
Updated•16 years ago
|
Flags: blocking1.9.1?
Target Milestone: --- → mozilla1.9.1
Comment 10•16 years ago
|
||
Let's get this landed on trunk. If it builds fine, I'll approve for 1.9.0.2 today, before code freeze.
Comment 11•16 years ago
|
||
Not blocking, but as I said, we'll take the patch after it lands safely on trunk.
Flags: blocking1.9.0.2? → blocking1.9.0.2-
Assignee | ||
Comment 12•16 years ago
|
||
So can someone with commit access commit it before code freeze?
Comment 13•16 years ago
|
||
Comment on attachment 335429 [details] [diff] [review] Add nsBadCertHandler.js to packages static [Checkin: Comment 14] Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #335429 -
Flags: approval1.9.0.2? → approval1.9.0.2+
Comment 14•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cc70c03d04a1 mozilla/browser/installer/unix/packages-static 1.162 mozilla/browser/installer/windows/packages-static 1.163
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed → fixed1.9.0.2
Resolution: --- → FIXED
Comment 15•16 years ago
|
||
Comment 16•16 years ago
|
||
Comment on attachment 335635 [details] [diff] [review] calendar patch [Checkin: Comment 16] mozilla/calendar/installer/windows/packages-static 1.74
Attachment #335635 -
Attachment description: calendar patch → [checked in] calendar patch
Comment 17•15 years ago
|
||
This landed before 1.9.1 branched
Updated•15 years ago
|
Attachment #335635 -
Attachment description: [checked in] calendar patch → calendar patch
[Checkin: Comment 16]
Updated•15 years ago
|
Attachment #335468 -
Attachment description: [checked in] Add to thunderbird's packages → Add to thunderbird's packages
[Checkin: Comment 8]
Updated•15 years ago
|
Attachment #335429 -
Attachment description: Add nsBadCertHandler.js to packages static → Add nsBadCertHandler.js to packages static
[Checkin: Comment 14]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•