nsBadCertHandler.js should be in packages-static

RESOLVED FIXED in mozilla1.9.1

Status

defect
P1
normal
RESOLVED FIXED
11 years ago
a year ago

People

(Reporter: mozbugs, Assigned: mozbugs)

Tracking

({fixed1.9.0.2, fixed1.9.1})

Trunk
mozilla1.9.1
Bug Flags:
blocking1.9.0.2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Bug #383430 added this for part of its functionality, so it needs to be distributed as well.
Flags: blocking1.9.0.2?
Attachment #335429 - Flags: review?(gavin.sharp)
(Assignee)

Updated

11 years ago
Flags: blocking-firefox3.1?
Attachment #335429 - Flags: review?(gavin.sharp) → review+
Other apps will want this as well, you should patch their packages-static (or equivalents) as well.
(Assignee)

Comment 2

11 years ago
Comment on attachment 335429 [details] [diff] [review]
Add nsBadCertHandler.js to packages static
[Checkin: Comment 14]

Requesting a1.9.0.2?. Patch applies to Firefox 3.0.x branch as well.
Attachment #335429 - Flags: approval1.9.0.2?
(Assignee)

Updated

11 years ago
Keywords: checkin-needed

Comment 3

11 years ago
(In reply to comment #1)
> Other apps will want this as well, you should patch their packages-static (or
> equivalents) as well.

I fixed that in bug 451740 for SeaMonkey.
(Assignee)

Comment 4

11 years ago
Is comm-central the only other place where there are Gecko 1.9.x based apps?
Assignee: nobody → manish
Status: NEW → ASSIGNED
Attachment #335467 - Flags: review?(gavin.sharp)
(Assignee)

Comment 5

11 years ago
(In reply to comment #3)
> (In reply to comment #1)
> > Other apps will want this as well, you should patch their packages-static (or
> > equivalents) as well.
> 
> I fixed that in bug 451740 for SeaMonkey.

Oops. New patch just for thunderbird coming up.

(Assignee)

Comment 6

11 years ago
OOC, why doesn't thunderbird have a unix packages-static?
Attachment #335467 - Attachment is obsolete: true
Attachment #335468 - Flags: review?(gavin.sharp)
Attachment #335467 - Flags: review?(gavin.sharp)
Comment on attachment 335468 [details] [diff] [review]
Add to thunderbird's packages
[Checkin: Comment 8]

Mostly, Tb/Linux doesn't have one because the closest anyone has ever come to offering a persuasive reason to have one is "maybe it would slightly increase the odds that a Linux-using dev would |make package| and realize that they forgot to add something." But despite the fact that I think that was *my* reason, I've never seen any real evidence that Fx's is providing that benefit :)
Attachment #335468 - Flags: review?(gavin.sharp) → review+
Comment on attachment 335468 [details] [diff] [review]
Add to thunderbird's packages
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/index.cgi/rev/1c152d460854
Attachment #335468 - Attachment description: Add to thunderbird's packages → [checked in] Add to thunderbird's packages
(In reply to comment #4)
> Is comm-central the only other place where there are Gecko 1.9.x based apps?

Calendar (Sunbird & Lightning) is still on the cvs trunk. If you patch the packages-static there as well, that would be great.
Component: Build Config → Build Config
Depends on: 451740
Flags: blocking-firefox3.1?
Product: Firefox → Core
QA Contact: build.config → build-config
Target Milestone: Firefox 3 → ---
Flags: blocking1.9.1?
Target Milestone: --- → mozilla1.9.1
Let's get this landed on trunk. If it builds fine, I'll approve for 1.9.0.2 today, before code freeze.
Not blocking, but as I said, we'll take the patch after it lands safely on trunk.
Flags: blocking1.9.0.2? → blocking1.9.0.2-
(Assignee)

Comment 12

11 years ago
So can someone with commit access commit it before code freeze? 
Comment on attachment 335429 [details] [diff] [review]
Add nsBadCertHandler.js to packages static
[Checkin: Comment 14]

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #335429 - Flags: approval1.9.0.2? → approval1.9.0.2+
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cc70c03d04a1

mozilla/browser/installer/unix/packages-static 	1.162
mozilla/browser/installer/windows/packages-static 	1.163 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Comment on attachment 335635 [details] [diff] [review]
calendar patch
[Checkin: Comment 16]

mozilla/calendar/installer/windows/packages-static 	1.74
Attachment #335635 - Attachment description: calendar patch → [checked in] calendar patch

Comment 17

10 years ago
This landed before 1.9.1 branched
Flags: blocking1.9.1? → blocking1.9.1+
Keywords: fixed1.9.1
Priority: -- → P1
Attachment #335635 - Attachment description: [checked in] calendar patch → calendar patch [Checkin: Comment 16]
Attachment #335468 - Attachment description: [checked in] Add to thunderbird's packages → Add to thunderbird's packages [Checkin: Comment 8]
Attachment #335429 - Attachment description: Add nsBadCertHandler.js to packages static → Add nsBadCertHandler.js to packages static [Checkin: Comment 14]

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.