Cleanup CookieViewer.xul

VERIFIED FIXED

Status

Core Graveyard
Skinability
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: roc, Assigned: Stephen P. Morse)

Tracking

({polish})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I have a patch that cleans up CookieViewer.xul in several ways:
-- changes occurrences of flex="100%" to flex="1"
-- makes trees size vertically to fill available space if the window is resized
-- makes cookie data text fields size horizontally to fill available space 
(useful for seeing long cookie data)
-- changes spring spacing to be consistent across panels
Status: NEW → ASSIGNED
Keywords: nsbeta3, polish

Comment 2

18 years ago
nav triage team: reassign to steve morse. patch attached.
Assignee: ben → morse
Status: ASSIGNED → NEW
Keywords: patch
(Assignee)

Comment 3

18 years ago
Fix checked in.  Great improvement.  Thanks.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 4

18 years ago
The new patch contains several skinability problems.  You cannot use style: in 
an XUL file.  Please handle element styling via id's and classes in external 
css files.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

18 years ago
Blake, could you please be more specific as to just what it is that shouldn't be 
used.  There were many instances of

    style="height: 5px;"

already in the file before this fix was made.

Comment 6

18 years ago
None of the widgets may have the style: attribute.  All styling must be done in 
external CSS files for skinability reasons.  This can be achieved by defining 
classes for elements and then styling those classes in the external CSS file 
(via .class { } ) or by styling the individual widgets by id (via #id { } ).
See other XUL/CSS files for examples.

Something like this is especially bad: <titledbox style="border: 2px groove 
#CCCCDD;" orient="vertical">.  All of these non-skinnable cases must be fixed 
for beta3...
Component: Cookies → Skinability
QA Contact: tever → BlakeR1234
(Assignee)

Comment 7

18 years ago
Then your comment has nothing to do with the patch per se but with the use of 
something that already existed in this xul file as well as many others.  Please 
file a separate bug report on the removal of styling in xul files making sure 
you list which xul files are the offenders in that bug report.

The work outlined in this bug report has been completed and so it is justifiable 
to mark this report as fixed.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 8

18 years ago
actually, the patch adds a couple of style attributes (for example:

-          <spring flex="5%"/>
+          <spring style="height: 5px;"/>

)

But I'll file a separate bug.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.