452206 - Remove OS X bundle-check hack from attachment code

Status: RESOLVED FIXED

(MailNews Core :: Attachments, defect)

Description

[Håkan Waara]

Now that bug 442401 is fixed, we can remove the hack I needed to workaround it in bug 372786.

Comment 1

[Håkan Waara]

Attachment: Patch v1

Here's the patch.  

It compiles, but still needs to be verified that the bug is gone is really gone now.

Comment 2

[Håkan Waara]

I don't have a working build atm. Henrik, would you be able to verify that with the patch, Keynote files still work correctly (i.e. that they are being recognized as bundles, and being zipped)?

Comment 3

[Håkan Waara]

(Note that you need the latest mozilla-central trunk with my fix for bug 442401 checked in, before applying & testing)

Comment 4

[David :Bienvenu]

Comment on attachment 335508 [details] [diff] [review]
Patch v1

this looks fine, but it would be great if someone could test this patch.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> I don't have a working build atm. Henrik, would you be able to verify that with
> the patch, Keynote files still work correctly (i.e. that they are being
> recognized as bundles, and being zipped)?

Sorry, but I haven't prepared my system to create hg builds yet. Hopefully you can find another one.

Comment 6

[David Ascher (:davida)]

I've tried the patch, and attaching the troublesome keynote file still WFM.

t=davida

Comment 7

[David :Bienvenu]

thx, marking checkin-needed

Comment 8

[Håkan Waara]

I'll check it in

Comment 9

[Håkan Waara]

Pushed f022678f2f2d