Closed Bug 452206 Opened 11 years ago Closed 11 years ago

Remove OS X bundle-check hack from attachment code

Categories

(MailNews Core :: Attachments, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hwaara, Assigned: hwaara)

References

Details

Attachments

(1 file)

Now that bug 442401 is fixed, we can remove the hack I needed to workaround it in bug 372786.
Attached patch Patch v1Splinter Review
Here's the patch.  

It compiles, but still needs to be verified that the bug is gone is really gone now.
Attachment #335508 - Flags: superreview?(bienvenu)
Attachment #335508 - Flags: review?(bienvenu)
I don't have a working build atm. Henrik, would you be able to verify that with the patch, Keynote files still work correctly (i.e. that they are being recognized as bundles, and being zipped)?
(Note that you need the latest mozilla-central trunk with my fix for bug 442401 checked in, before applying & testing)
Comment on attachment 335508 [details] [diff] [review]
Patch v1

this looks fine, but it would be great if someone could test this patch.
Attachment #335508 - Flags: superreview?(bienvenu)
Attachment #335508 - Flags: superreview+
Attachment #335508 - Flags: review?(bienvenu)
Attachment #335508 - Flags: review+
(In reply to comment #2)
> I don't have a working build atm. Henrik, would you be able to verify that with
> the patch, Keynote files still work correctly (i.e. that they are being
> recognized as bundles, and being zipped)?

Sorry, but I haven't prepared my system to create hg builds yet. Hopefully you can find another one.
Hardware: PC → All
Version: unspecified → Trunk
I've tried the patch, and attaching the troublesome keynote file still WFM.

t=davida
thx, marking checkin-needed
Keywords: checkin-needed
I'll check it in
Keywords: checkin-needed
Pushed f022678f2f2d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.