Closed
Bug 452315
Opened 16 years ago
Closed 16 years ago
nanojit build fails on FreeBSD
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: reg, Unassigned)
Details
Attachments
(1 file)
|
316 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Compile fails due a missing declaration of valloc(), which is defined in <unistd.h> on FreeBSD. The attached patch fixes this, although this might not be the right fix... Should it be using jemalloc?
Attachment #335620 -
Flags: superreview?(brendan)
Attachment #335620 -
Flags: review?(brendan)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 335620 [details] [diff] [review] Include <unistd.h> on FreeBSD We don't require sr in js/src. Deferring to danderson on js/src/nanojit patches. /be
Attachment #335620 -
Flags: superreview?(brendan)
Attachment #335620 -
Flags: review?(danderson)
Attachment #335620 -
Flags: review?(brendan)
|
||
Updated•16 years ago
|
Attachment #335620 -
Flags: review?(danderson) → review+
Pushed fix to tracemonkey repo as changeset 4275d8069411; thanks!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•