Closed
Bug 452415
Opened 16 years ago
Closed 16 years ago
Switch from <textbox type="timed"> to type="search" in SeaMonkey
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(3 files, 2 obsolete files)
3.36 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
2.80 KB,
patch
|
mnyromyr
:
review+
|
Details | Diff | Splinter Review |
4.19 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
I understand that toolkit wants to get rid of type="timed" anyway.
Assignee | ||
Comment 1•16 years ago
|
||
Trying KaiRo for review because he wrote the applications pane.
Assignee | ||
Comment 2•16 years ago
|
||
Interestingly the main clear button entities are reused from messenger.dtd and Thunderbird has a different sidebar and no addressing dialog.
Attachment #335709 -
Flags: review?(bugzilla)
Assignee | ||
Comment 3•16 years ago
|
||
...since subscribe.xul is still shared, right?
Attachment #335715 -
Flags: superreview?(bienvenu)
Attachment #335715 -
Flags: review?(philringnalda)
Attachment #335715 -
Flags: review?(mnyromyr)
Assignee | ||
Comment 4•16 years ago
|
||
The real patch this time...
Attachment #335709 -
Attachment is obsolete: true
Attachment #335716 -
Flags: superreview?(dmose)
Attachment #335716 -
Flags: review?(bugzilla)
Attachment #335709 -
Flags: review?(bugzilla)
Comment 5•16 years ago
|
||
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/
yes, afaik it's shared. TB doesn't have its own.
Will the timeout for quick search change now?
Attachment #335715 -
Flags: superreview?(bienvenu) → superreview+
Comment 6•16 years ago
|
||
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/
Nope, not shared - I already changed our fork, though I didn't have quite enough nerve to drop the 300ms timeout even though I don't have any idea how it was chosen.
Attachment #335715 -
Flags: superreview?(bienvenu)
Attachment #335715 -
Flags: superreview+
Attachment #335715 -
Flags: review?(philringnalda)
Comment 7•16 years ago
|
||
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/
Which, fortunately, means you don't need the sr that you had before I midaired it.
Attachment #335715 -
Flags: superreview?(bienvenu)
Updated•16 years ago
|
Version: unspecified → Trunk
Comment 8•16 years ago
|
||
Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/
>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/abSelectAddressesDialog.xul
>--- a/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul Wed Aug 27 16:39:30 2008 +0100
>@@ -81,11 +81,9 @@
> <menupopup id="addressbookList-menupopup" class="addrbooksPopup"/>
> </menulist>
> <label value="&for.label;" accesskey="&for.accesskey;" control="searchInput"/>
>- <textbox id="searchInput" flex="1"
>- type="timed" timeout="800"
>+ <textbox id="searchInput" flex="1" type="search"
> oninput="SearchInputChanged();"
> oncommand="onEnterInSearchBar();"/>
>- <button id="clear" label="&clearButton.label;" disabled="true" accesskey="&clearButton.accesskey;" oncommand="onAbClearSearch();"/>
> </hbox>
If I understand this right, I believe we don't need onAbClearSearch except for addressbook-panel (which requires it for compose-window-close notifications), so I think we should be moving that function from abCommon.js to addressbook-panel.js.
>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/addressbook.xul
>--- a/mailnews/addrbook/resources/content/addressbook.xul Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/addressbook.xul Wed Aug 27 16:39:30 2008 +0100
>@@ -246,7 +246,8 @@
> accesskey="&propertiesCmd.accesskey;"
> key="key_properties"
> command="cmd_properties"/>
>- <menuitem id="menu_preferences" oncommand="goPreferences('mailnews', 'chrome://messenger/content/addressbook/pref-addressing.xul', 'mailaddressbookpref')"/>
>+ <menuitem id="menu_preferences"
>+ oncommand="goPreferences('addressing_pane')"/>
> </menupopup>
> </menu>
> <menu id="menu_View">
This is a different bug...
r=me with those fixed.
Also, all the bits here are TB-specific, so you shouldn't need Dan as an sr.
Attachment #335716 -
Flags: review?(bugzilla) → review+
Updated•16 years ago
|
Attachment #335716 -
Flags: review+ → review-
Comment 9•16 years ago
|
||
Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/
I forgot, I'm getting the following error on searching in the select addresses dialog:
JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 636: gSearchInput.nextSibling is null
Updated•16 years ago
|
Attachment #335715 -
Flags: review?(mnyromyr) → review+
Comment 10•16 years ago
|
||
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/
Now we just need TB's search term context menu, too, for extra coolness. ;-)
Assignee | ||
Comment 11•16 years ago
|
||
Attachment #335716 -
Attachment is obsolete: true
Attachment #336174 -
Flags: review?(bugzilla)
Attachment #335716 -
Flags: superreview?(dmose)
Updated•16 years ago
|
Attachment #335705 -
Flags: review?(kairo) → review+
Comment 12•16 years ago
|
||
Comment on attachment 335705 [details] [diff] [review]
Patch for suite/
From what I see, it seems to work alright. I'm too little expert on the code, but the patch looks alright to me.
Comment 13•16 years ago
|
||
Comment on attachment 336174 [details] [diff] [review]
Revised patch for mailnews/addrbook/
r=me if you put the abSelectAddressesDialog.dtd changes back in.
Attachment #336174 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 14•16 years ago
|
||
Pushed changeset ebd2167a2511 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Summary: Switch from <textbox type="timed"> to type="search" → Switch from <textbox type="timed"> to type="search" in SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•