452415 - Switch from <textbox type="timed"> to type="search" in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

I understand that toolkit wants to get rid of type="timed" anyway.

Comment 1

[[e-mail]]

Attachment: Patch for suite/

Trying KaiRo for review because he wrote the applications pane.

Comment 2

[[e-mail]]

Attachment: Patch for mailnews/addrbook/

Interestingly the main clear button entities are reused from messenger.dtd and Thunderbird has a different sidebar and no addressing dialog.

Comment 3

[[e-mail]]

Attachment: Patch for mailnews/base/

...since subscribe.xul is still shared, right?

Comment 4

[[e-mail]]

Attachment: Patch for mailnews/addrbook/

The real patch this time...

Comment 5

[David :Bienvenu]

Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

yes, afaik it's shared. TB doesn't have its own.
Will the timeout for quick search change now?

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Nope, not shared - I already changed our fork, though I didn't have quite enough nerve to drop the 300ms timeout even though I don't have any idea how it was chosen.

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Which, fortunately, means you don't need the sr that you had before I midaired it.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/

>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/abSelectAddressesDialog.xul
>--- a/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul	Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul	Wed Aug 27 16:39:30 2008 +0100
>@@ -81,11 +81,9 @@
>         <menupopup id="addressbookList-menupopup" class="addrbooksPopup"/>
>       </menulist>  
>       <label value="&for.label;" accesskey="&for.accesskey;" control="searchInput"/>
>-      <textbox id="searchInput" flex="1"
>-               type="timed" timeout="800"
>+      <textbox id="searchInput" flex="1" type="search"
>                oninput="SearchInputChanged();"
>                oncommand="onEnterInSearchBar();"/>  
>-      <button id="clear" label="&clearButton.label;" disabled="true" accesskey="&clearButton.accesskey;" oncommand="onAbClearSearch();"/>
>     </hbox>

If I understand this right, I believe we don't need onAbClearSearch except for addressbook-panel (which requires it for compose-window-close notifications), so I think we should be moving that function from abCommon.js to addressbook-panel.js.

>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/addressbook.xul
>--- a/mailnews/addrbook/resources/content/addressbook.xul	Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/addressbook.xul	Wed Aug 27 16:39:30 2008 +0100
>@@ -246,7 +246,8 @@
>                       accesskey="&propertiesCmd.accesskey;"
>                       key="key_properties"
>                       command="cmd_properties"/>
>-            <menuitem id="menu_preferences" oncommand="goPreferences('mailnews', 'chrome://messenger/content/addressbook/pref-addressing.xul', 'mailaddressbookpref')"/>
>+            <menuitem id="menu_preferences"
>+                      oncommand="goPreferences('addressing_pane')"/>
>           </menupopup>
>         </menu>
>         <menu id="menu_View">

This is a different bug...

r=me with those fixed.

Also, all the bits here are TB-specific, so you shouldn't need Dan as an sr.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/

I forgot, I'm getting the following error on searching in the select addresses dialog:

JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 636: gSearchInput.nextSibling is null

Comment 10

[Karsten Düsterloh]

Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Now we just need TB's search term context menu, too, for extra coolness. ;-)

Comment 11

[[e-mail]]

Attachment: Revised patch for mailnews/addrbook/

Comment 12

[Robert Kaiser]

Comment on attachment 335705 [details] [diff] [review]
Patch for suite/

From what I see, it seems to work alright. I'm too little expert on the code, but the patch looks alright to me.

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 336174 [details] [diff] [review]
Revised patch for mailnews/addrbook/

r=me if you put the abSelectAddressesDialog.dtd changes back in.

Comment 14

[[e-mail]]

Pushed changeset ebd2167a2511 to comm-central.