The default bug view has changed. See this FAQ.

Switch from <textbox type="timed"> to type="search" in SeaMonkey

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

(Assignee)

Description

9 years ago
I understand that toolkit wants to get rid of type="timed" anyway.
(Assignee)

Comment 1

9 years ago
Created attachment 335705 [details] [diff] [review]
Patch for suite/

Trying KaiRo for review because he wrote the applications pane.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #335705 - Flags: review?(kairo)
(Assignee)

Comment 2

9 years ago
Created attachment 335709 [details] [diff] [review]
Patch for mailnews/addrbook/

Interestingly the main clear button entities are reused from messenger.dtd and Thunderbird has a different sidebar and no addressing dialog.
Attachment #335709 - Flags: review?(bugzilla)
(Assignee)

Comment 3

9 years ago
Created attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

...since subscribe.xul is still shared, right?
Attachment #335715 - Flags: superreview?(bienvenu)
Attachment #335715 - Flags: review?(philringnalda)
Attachment #335715 - Flags: review?(mnyromyr)
(Assignee)

Comment 4

9 years ago
Created attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/

The real patch this time...
Attachment #335709 - Attachment is obsolete: true
Attachment #335716 - Flags: superreview?(dmose)
Attachment #335716 - Flags: review?(bugzilla)
Attachment #335709 - Flags: review?(bugzilla)

Comment 5

9 years ago
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

yes, afaik it's shared. TB doesn't have its own.
Will the timeout for quick search change now?
Attachment #335715 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Nope, not shared - I already changed our fork, though I didn't have quite enough nerve to drop the 300ms timeout even though I don't have any idea how it was chosen.
Attachment #335715 - Flags: superreview?(bienvenu)
Attachment #335715 - Flags: superreview+
Attachment #335715 - Flags: review?(philringnalda)
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Which, fortunately, means you don't need the sr that you had before I midaired it.
Attachment #335715 - Flags: superreview?(bienvenu)
Version: unspecified → Trunk
Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/

>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/abSelectAddressesDialog.xul
>--- a/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul	Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/abSelectAddressesDialog.xul	Wed Aug 27 16:39:30 2008 +0100
>@@ -81,11 +81,9 @@
>         <menupopup id="addressbookList-menupopup" class="addrbooksPopup"/>
>       </menulist>  
>       <label value="&for.label;" accesskey="&for.accesskey;" control="searchInput"/>
>-      <textbox id="searchInput" flex="1"
>-               type="timed" timeout="800"
>+      <textbox id="searchInput" flex="1" type="search"
>                oninput="SearchInputChanged();"
>                oncommand="onEnterInSearchBar();"/>  
>-      <button id="clear" label="&clearButton.label;" disabled="true" accesskey="&clearButton.accesskey;" oncommand="onAbClearSearch();"/>
>     </hbox>

If I understand this right, I believe we don't need onAbClearSearch except for addressbook-panel (which requires it for compose-window-close notifications), so I think we should be moving that function from abCommon.js to addressbook-panel.js.

>diff -r 4b62be6f26a1 mailnews/addrbook/resources/content/addressbook.xul
>--- a/mailnews/addrbook/resources/content/addressbook.xul	Tue Aug 26 22:40:20 2008 +0100
>+++ b/mailnews/addrbook/resources/content/addressbook.xul	Wed Aug 27 16:39:30 2008 +0100
>@@ -246,7 +246,8 @@
>                       accesskey="&propertiesCmd.accesskey;"
>                       key="key_properties"
>                       command="cmd_properties"/>
>-            <menuitem id="menu_preferences" oncommand="goPreferences('mailnews', 'chrome://messenger/content/addressbook/pref-addressing.xul', 'mailaddressbookpref')"/>
>+            <menuitem id="menu_preferences"
>+                      oncommand="goPreferences('addressing_pane')"/>
>           </menupopup>
>         </menu>
>         <menu id="menu_View">

This is a different bug...

r=me with those fixed.

Also, all the bits here are TB-specific, so you shouldn't need Dan as an sr.
Attachment #335716 - Flags: review?(bugzilla) → review+
Attachment #335716 - Flags: review+ → review-
Comment on attachment 335716 [details] [diff] [review]
Patch for mailnews/addrbook/

I forgot, I'm getting the following error on searching in the select addresses dialog:

JavaScript error: chrome://messenger/content/addressbook/abCommon.js, line 636: gSearchInput.nextSibling is null

Updated

9 years ago
Attachment #335715 - Flags: review?(mnyromyr) → review+

Comment 10

9 years ago
Comment on attachment 335715 [details] [diff] [review]
Patch for mailnews/base/

Now we just need TB's search term context menu, too, for extra coolness. ;-)
(Assignee)

Comment 11

9 years ago
Created attachment 336174 [details] [diff] [review]
Revised patch for mailnews/addrbook/
Attachment #335716 - Attachment is obsolete: true
Attachment #336174 - Flags: review?(bugzilla)
Attachment #335716 - Flags: superreview?(dmose)

Updated

9 years ago
Attachment #335705 - Flags: review?(kairo) → review+

Comment 12

9 years ago
Comment on attachment 335705 [details] [diff] [review]
Patch for suite/

From what I see, it seems to work alright. I'm too little expert on the code, but the patch looks alright to me.
Comment on attachment 336174 [details] [diff] [review]
Revised patch for mailnews/addrbook/

r=me if you put the abSelectAddressesDialog.dtd changes back in.
Attachment #336174 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 14

9 years ago
Pushed changeset ebd2167a2511 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Apps: GUI Features → UI Design

Updated

9 years ago
Duplicate of this bug: 125185

Updated

8 years ago
Duplicate of this bug: 449690
Depends on: 388811
Blocks: 449045
Summary: Switch from <textbox type="timed"> to type="search" → Switch from <textbox type="timed"> to type="search" in SeaMonkey

Updated

7 years ago
Blocks: 533956
You need to log in before you can comment on or make changes to this bug.