ASSERTION: null data pointer: 'Not Reached', file nsTSubstring.cpp, line 667

RESOLVED FIXED

Status

()

Core
Printing: Output
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Martin Mokrejs, Assigned: dholbert)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2008082711 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2008082711 SeaMonkey/2.0a1pre

With current TRUNK build when I open Print preview it generates the following error:

ASSERTION: null data pointer: 'Not Reached', file nsTSubstring.cpp, line 667

Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Build platform
target
i686-pc-linux-gnu

Build tools
Compiler 	Version 	Compiler flags
gcc 	gcc version 4.3.1 (Gentoo 4.3.1-r1 p1.1) 	-Wall -W -Wno-unused -Wpointer-arith -Wcast-align -W -Wno-long-long -pedantic -fno-strict-aliasing -pthread -pipe
c++ 	gcc version 4.3.1 (Gentoo 4.3.1-r1 p1.1) 	-fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe

Configure arguments
--disable-optimize '--enable-debug=-g3\ -O0\ -ggdb' --enable-debug-modules=all --enable-debugger-info-modules --enable-detect-webshell-leaks --enable-svg --enable-svg-renderer-libart --enable-image-decoders=all --with-qtdir=/usr/qt/3 --enable-application=suite --disable-freetype2 --enable-jprof --enable-default-toolkit=cairo-gtk2 --enable-xft --disable-gssapi

Updated

10 years ago
Component: General → Print Preview
Product: Firefox → Core
QA Contact: general → printing
(Assignee)

Comment 1

10 years ago
I see this assertion as well, using an up-to-date debug trunk build.  I tried print-previewing about:blank (as well as a few web pages).
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → Trunk
(Assignee)

Comment 2

10 years ago
I also hit this assertion simply from hitting Ctrl-P to pop up the print dialog.  (No actual printing, or any further action, is required.)
(Assignee)

Comment 3

10 years ago
Created attachment 335837 [details] [diff] [review]
trivial patch v1

So despite the scary-sounding assertion, this is actually just a minor issue, with a trivial fix.  

Basically, we start out with a null printer-name inside of nsPrintSettingsGTK::mPrintSettings.  At some point, we pass that null pointer as an argument to nsTSubstring::Equals(const char* data), and that function complains about the null argument.  (But it still handles it gracefully -- hence, this bug doesn't cause any real problems).

This patch fixes the bug by null-checking the pointer before passing it in to Equals().
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Assignee: dholbert → nobody
Status: ASSIGNED → NEW
Component: Print Preview → Printing: Setup
QA Contact: printing → printing.setup
(Assignee)

Updated

10 years ago
Assignee: nobody → dholbert
(Assignee)

Updated

10 years ago
Assignee: dholbert → nobody
Component: Printing: Setup → Printing: Output
QA Contact: printing.setup → printing
(Assignee)

Updated

10 years ago
Assignee: nobody → dholbert
(Assignee)

Updated

10 years ago
Attachment #335837 - Flags: superreview?(roc)
Attachment #335837 - Flags: review?(roc)
(Assignee)

Updated

10 years ago
Flags: wanted1.9.1?
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Attachment #335837 - Flags: superreview?(roc)
Attachment #335837 - Flags: superreview+
Attachment #335837 - Flags: review?(roc)
Attachment #335837 - Flags: review+
(Assignee)

Comment 4

10 years ago
Patch pushed to mozilla-central as changeset f77d2bda6a36
http://hg.mozilla.org/mozilla-central/index.cgi/rev/f77d2bda6a36
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Flags: wanted1.9.1?
You need to log in before you can comment on or make changes to this bug.