452492 - Fennec logo in maemo menu.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Antonio Gomes (tonikitoo)]

No logo is being used for Fennec in menu, after installed.

Comment 1

[Antonio Gomes (tonikitoo)]

Attachment: add support to fennec logo in menu

Comment 2

[Antonio Gomes (tonikitoo)]

Attachment: 64x64 transparent background icon for fennec in menu

if madhava review+ it , it has to be push in mobile/installer/debian/

Comment 3

[Antonio Gomes (tonikitoo)]

is should look like

https://bugzilla.mozilla.org/attachment.cgi?id=335555

at the end.

Comment 4

[Antonio Gomes (tonikitoo)]

(In reply to comment #2)
> Created an attachment (id=335764) [details]
> 64x64 transparent background icon for fennec in menu
> 
> if madhava review+ it , it has to be push in mobile/installer/debian/
> 

ops , icon should be pushed as mobile/installer/debian/fennec_scalable.png

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 335763 [details] [diff] [review]
add support to fennec logo in menu


>+	$(NSINSTALL) -D $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/
>+	cp debian/$(MOZ_APP_NAME)_scalable.png $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png

just install directly from the src dir
$(NSINSTALL) $(srcdir)/debian/$(MOZ_APP_NAME)_scalable.png $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png

> #	$(NSINSTALL) -m 755 debian/postinst debian/$(MOZ_APP_NAME)/DEBIAN
> 	dh_link; fakeroot dh_fixperms; 	dh_shlibdeps; fakeroot dh_gencontrol; fakeroot dh_md5sums; dh_builddeb
> endif
>diff -r 02edca6b16db installer/debian/fennec_scalable.png
>Binary file installer/debian/fennec_scalable.png has changed
>diff -r 02edca6b16db makefiles.sh
>--- a/makefiles.sh	Tue Aug 26 10:47:58 2008 -0500
>+++ b/makefiles.sh	Wed Aug 27 16:30:35 2008 -0400
>@@ -47,6 +47,7 @@ mobile/installer/debian/fennec.desktop
> mobile/installer/debian/fennec.desktop
> mobile/installer/debian/fennec.links
> mobile/installer/debian/fennec.service
>+mobile/installer/debian/fennec_scalable.png
> mobile/installer/debian/files
> mobile/installer/debian/icon_base64
> mobile/installer/debian/menu"


the image should be preprocessed, drop this change

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

> 
> the image should be preprocessed, drop this change
> 

err....the image shouldn't be preprocessed, drop this change

Comment 7

[Antonio Gomes (tonikitoo)]

> >+	$(NSINSTALL) -D $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/
> >+	cp debian/$(MOZ_APP_NAME)_scalable.png $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png
> 
> just install directly from the src dir
> $(NSINSTALL) $(srcdir)/debian/$(MOZ_APP_NAME)_scalable.png
> $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png

Ok, lets install directly but doing this way icon will end up like:

/usr/share/icons/hicolor/scalable/hildon/fennec.png/fennec_scalable.png

it has to be:

        $(NSINSTALL) -D $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/
        cp $(srcdir)/debian/$(MOZ_APP_NAME)_scalable.png $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png

as done for 'fennec.service'. Is that ok ?

> the image shouldn't be preprocessed, drop this change

k

Comment 8

[Antonio Gomes (tonikitoo)]

Attachment: right patch according to comment #7

Comment 9

[Antonio Gomes (tonikitoo)]

Comment on attachment 335789 [details] [diff] [review]
right patch according to comment  #7

>diff -r 02edca6b16db installer/Makefile.in
>--- a/installer/Makefile.in	Tue Aug 26 10:47:58 2008 -0500
>+++ b/installer/Makefile.in	Wed Aug 27 18:24:24 2008 -0400
>@@ -86,6 +86,8 @@ deb: debian/control
> 	$(NSINSTALL)  debian/$(MOZ_APP_NAME).desktop $(DEBDESTDIR)/usr/share/applications/hildon/
> 	$(NSINSTALL) -D $(DEBDESTDIR)/usr/share/dbus-1/services/
> 	cp debian/$(MOZ_APP_NAME).service $(DEBDESTDIR)/usr/share/dbus-1/services/org.mozilla.$(MOZ_APP_NAME).service
>+	$(NSINSTALL) -D $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/
>+	cp $(srcdir)/debian/$(MOZ_APP_NAME)_scalable.png $(DEBDESTDIR)/usr/share/icons/hicolor/scalable/hildon/$(MOZ_APP_NAME).png
> #	$(NSINSTALL) -m 755 debian/postinst debian/$(MOZ_APP_NAME)/DEBIAN
> 	dh_link; fakeroot dh_fixperms; 	dh_shlibdeps; fakeroot dh_gencontrol; fakeroot dh_md5sums; dh_builddeb
> endif

Comment 10

[Antonio Gomes (tonikitoo)]

Attachment: fixed mistyped "srcdir"

Comment 11

[Antonio Gomes (tonikitoo)]

Attachment: update to mobile "trunk"

Comment 12

[Antonio Gomes (tonikitoo)]

Attachment: final patch

Final patch. It includes the image.

create with :

> hg diff -w --git

applyable with:

git-apply <patch>

ps: do not know how to apply patch w/ binary file in it.

Comment 13

[Antonio Gomes (tonikitoo)]

brad has pushed.

767c0315369c

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta3.