452531 - Change the url for eBay search plug-in for (fr)

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Mic Berman]

please change the url for the eBay search plug in per a request from eBay due
to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/709-47295-17703-3/4?satitle={searchTerms}

this will require a patch

Comment 1

[Staś Małolepszy :stas]

OK, we have confirmation from eBay that satitle is the only paramter to be used in the URL.

Something like:
<Param name="satitle" value="{searchTerms}"/>
should do the trick (with all other <params/> removed and URL's template changed).

Thanks!

Comment 2

[Bugzilla FR]

Attachment: patch to comply to directions given in the bug

Asking review to Stas.

Comment 3

[Staś Małolepszy :stas]

Thank you.

A quick note: we are actually making this change for both current trunk (hg) and 1.9.0.x (cvs trunk). The patch on CVS will need to get an approval1.9.0.3.

Comment 4

[Bugzilla FR]

Attachment: New version with spaces instead of tab

New version of the patch.
Asking approval for 1.9.0.3 (and 1.9.1)

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 339505 [details] [diff] [review]
New version with spaces instead of tab

r=me. The patch can land on hg. For CVS, I set the approval1.9.0.3 to '?'. 

Thanks Philippe :)

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 339505 [details] [diff] [review]
New version with spaces instead of tab

a=me for 3.0.3, please land with a check-in comment referencing this bug and stas' review/my approval. Use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and testing.

Comment 7

[Bugzilla FR]

Do we need approval for 1.9.0.4 ?

Comment 8

[Staś Małolepszy :stas]

Yes, and looking at the patch details, it seems that we have it :)

Comment 9

[Bugzilla FR]

cvs commit: Examining .
Checking in eBay-france.xml;
/l10n/l10n/fr/browser/searchplugins/eBay-france.xml,v  <--  eBay-france.xml
new revision: 1.3; previous revision: 1.2
done

Comment 10

[Bugzilla FR]

verified, fixed, closing the bug.

Mozilla/5.0 (X11; U; Linux i686 (x86_64); fr; rv:1.9.0.4pre) Gecko/2008100204 GranParadiso/3.0.4pre ID:2008100204