Change the url for eBay search plug-in for (fr)

RESOLVED FIXED

Status

Mozilla Localizations
fr / French
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Mic Berman, Assigned: Bugzilla FR)

Tracking

({fixed1.9.0.4, verified1.9.0.4})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
please change the url for the eBay search plug in per a request from eBay due
to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/709-47295-17703-3/4?satitle={searchTerms}

this will require a patch
OK, we have confirmation from eBay that satitle is the only paramter to be used in the URL.

Something like:
<Param name="satitle" value="{searchTerms}"/>
should do the trick (with all other <params/> removed and URL's template changed).

Thanks!
(Assignee)

Comment 2

10 years ago
Created attachment 338705 [details] [diff] [review]
patch to comply to directions given in the bug

Asking review to Stas.
Attachment #338705 - Flags: review?(stas)
Thank you.

A quick note: we are actually making this change for both current trunk (hg) and 1.9.0.x (cvs trunk). The patch on CVS will need to get an approval1.9.0.3.
(Assignee)

Comment 4

10 years ago
Created attachment 339505 [details] [diff] [review]
New version with spaces instead of tab

New version of the patch.
Asking approval for 1.9.0.3 (and 1.9.1)
Attachment #338705 - Attachment is obsolete: true
Attachment #339505 - Flags: approval1.9.0.3?
Attachment #338705 - Flags: review?(stas)
(Assignee)

Updated

10 years ago
Attachment #339505 - Flags: approval1.9.0.3? → review?(stas)
Comment on attachment 339505 [details] [diff] [review]
New version with spaces instead of tab

r=me. The patch can land on hg. For CVS, I set the approval1.9.0.3 to '?'. 

Thanks Philippe :)
Attachment #339505 - Flags: review?(stas)
Attachment #339505 - Flags: review+
Attachment #339505 - Flags: approval1.9.0.3?

Updated

10 years ago
Attachment #339505 - Flags: approval1.9.0.3? → approval1.9.0.3+

Comment 6

10 years ago
Comment on attachment 339505 [details] [diff] [review]
New version with spaces instead of tab

a=me for 3.0.3, please land with a check-in comment referencing this bug and stas' review/my approval. Use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and testing.
(Assignee)

Comment 7

10 years ago
Do we need approval for 1.9.0.4 ?
Yes, and looking at the patch details, it seems that we have it :)
(Assignee)

Updated

10 years ago
Keywords: fixed1.9.0.4
(Assignee)

Comment 9

10 years ago
cvs commit: Examining .
Checking in eBay-france.xml;
/l10n/l10n/fr/browser/searchplugins/eBay-france.xml,v  <--  eBay-france.xml
new revision: 1.3; previous revision: 1.2
done
(Assignee)

Comment 10

10 years ago
verified, fixed, closing the bug.

Mozilla/5.0 (X11; U; Linux i686 (x86_64); fr; rv:1.9.0.4pre) Gecko/2008100204 GranParadiso/3.0.4pre ID:2008100204
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: verified1.9.0.4
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.