452532 - Change the url for eBay search plug-in for (it)

Status: VERIFIED FIXED

(Mozilla Localizations :: it / Italian, defect)

Description

[Mic Berman]

please change the url for the eBay search plug in per a request from eBay due
to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/724-51951-19398-1/4?satitle={searchTerms}

i have tested this and the url works fine

this will require a patch

Comment 1

[Francesco Lodolo [:flod]]

Hi Mic,
do you have a working example of this plugin?

I tried to change the URL with this new one, but it doesn't work at all: it considers the first parameter after the url as part of the search terms (so it doesn't find anything).

I can make a working plugin using the "satitle" as a parameter and not as part of the URL, like this

<Url type="text/html" method="GET" template="http://rover.ebay.com/rover/1/724-51951-19398-1/4">
  <Param name="satitle" value="{searchTerms}"/>
  <Param name="MfcISAPICommand" value="GetResult"/>
  <Param name="ht" value="1"/>
  <Param name="ebaytag1" value="ebayreg"/>
  <Param name="srchdesc" value="n"/>
  <Param name="maxRecordsReturned" value="300"/>
  <Param name="maxRecordsPerPage" value="50"/>
  <Param name="SortProperty" value="MetaEndSort"/>
</Url>

Other questions: 
* do we need review&patch also for trunk (mercurial)?
* the firefox 3.0.x is the current CVS trunk and I need the flag approval1.9.0.3. Is it right?

Comment 2

[Axel Hecht [:Pike]]

Yes, patches on hg to search plugins and region.properties need to go through review, and review plus approval on the frozen cvs trunk. Thanks

satitle is surely supposed to be a Param, I kinda thought we were supposed to drop all other params. Mic, Seth, can you confirm that?

Comment 3

[Staś Małolepszy :stas]

OK, we have confirmation from eBay that satitle is the only paramter to be used in the URL.

Something like:
<Param name="satitle" value="{searchTerms}"/>
should do the trick (with all other <params/> removed and URL's template changed).

Thanks!

Comment 4

[Francesco Lodolo [:flod]]

Attachment: eBay-it searchplugin patch for 1.9.0.x (Firefox 3.0.x)

CVS Patch for Firefox 3.0.x

Comment 5

[Francesco Lodolo [:flod]]

Attachment: eBay-it searchplugin patch for Firefox 3.1

Mercurial Patch for Firefox 3.1

Comment 6

[Staś Małolepszy :stas]

Comment on attachment 338686 [details] [diff] [review]
eBay-it searchplugin patch for 1.9.0.x (Firefox 3.0.x)


> <SearchForm>http://search.ebay.com/</SearchForm>

Don't you want to change that to search.ebay.it? <searchform/> specifies the URL to go to when the user presses enter and the searchbox is empty.

Also, I think 3.0.2 is going out tomorrow, so probably you'll need approval1.9.0.3, not .2.

Comment 7

[Francesco Lodolo [:flod]]

Attachment: eBay-it searchplugin patch for Firefox 3.1

Hg patch with updated Searchform parameter

Comment 8

[Francesco Lodolo [:flod]]

Attachment: eBay-it searchplugin patch for 1.9.0.x (Firefox 3.0.x)

CVS patch with updated Searchform parameter

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 338708 [details] [diff] [review]
eBay-it searchplugin patch for Firefox 3.1

r=me

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 338710 [details] [diff] [review]
eBay-it searchplugin patch for 1.9.0.x (Firefox 3.0.x)

r=me

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 338710 [details] [diff] [review]
eBay-it searchplugin patch for 1.9.0.x (Firefox 3.0.x)

a=me for 3.0.3. Please land this with a check-in comment referencing this bug and my approval and stas' review.

Please use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and testing.

Comment 12

[Francesco Lodolo [:flod]]

CVS check-in

Checking in eBay-it.xml;
/l10n/l10n/it/browser/searchplugins/eBay-it.xml,v  <--  eBay-it.xml
new revision: 1.3; previous revision: 1.2
done

Hg check-in
http://hg.mozilla.org/l10n-central/it/rev/3c4e3ce58c34

Comment 13

[Francesco Lodolo [:flod]]

Verified Hg 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.1b1pre) Gecko/20080919020347 Minefield/3.1b1pre

Comment 14

[Francesco Lodolo [:flod]]

Verified CVS

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; it; rv:1.9.0.3pre) Gecko/2008092004 GranParadiso/3.0.3pre