452533 - Change the url for eBay search plug-in for (es)

Status: VERIFIED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Mic Berman]

please change the url for the eBay search plug in per a request from eBay due
to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/1185-51955-19398-1/4?satitle={searchTerms}

i have tested this url and it works fine

this will require a patch

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Patch for 1.9.0.x as well as for mozilla-central, isn't it?

Comment 2

[Axel Hecht [:Pike]]

Yes, please, and an approval1.9.0.3 request in addition to the review request for 1.9.0.x. Thanks.

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for eBay-es.xml

Patch for eBay-es.xml as requested.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 335967 [details] [diff] [review]
Patch for eBay-es.xml

r-, this patch is broken.

Please back it out on hg, too.

As a general rule, fixes that require patches require review *before* landing. This is not about book keeping, this is about catching errors before they land.

I'll leave it up to Stas to guide you to the right patch, because I don't have the full spec myself. I do know that this one is broken, though.

Comment 5

[Staś Małolepszy :stas]

Guys, please hold on for a couple of days while we're getting a confirmation from eBay on the set of query parameters. I'll get back to you as soon as we're sure about those.

Thanks!

Comment 6

[Guillermo López :willyaranda (probably SLOW response)]

Ok, no problem. Sorry for that.

Comment 7

[Staś Małolepszy :stas]

OK, we have confirmation from eBay that satitle is the only parameter to be used in the URL.

Something like:
<Param name="satitle" value="{searchTerms}"/>
should do the trick (with all other <params/> removed and URL's template changed).

Thanks!

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

If I change the search plugin locally to:

<Url type="text/html" method="GET" template="http://rover.ebay.com/rover/1/1185-51955-19398-1/4?satitle={searchTerms}">
	<Param name="satitle" value="{searchTerms}"/>

as mic said on description and try to search, I get that URL:

http://search.ebay.es/busatitle-bu_W0QQsatitleZbusatitleQ3dbu

which is not correct, but if I change the URL template to:

http://rover.ebay.com/rover/1/1185-51955-19398-1/4?{searchTerms}

I get the correct URL (well, I get the exact term searched). So, waiting your comment, Staś.

Comment 9

[Axel Hecht [:Pike]]

... and when you have the param in a param, the template needs to change, of course.

<Url type="text/html" method="GET"
template="http://rover.ebay.com/rover/1/1185-51955-19398-1/4">

Comment 10

[Staś Małolepszy :stas]

Yep, sorry for not specifying this explicitly: using the <param/> means that we don't need any ?params= in the URL's template.

Comment 11

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: New patch

New patch with suggestions of Staś and Pike.

Comment 12

[Staś Małolepszy :stas]

Hi Guillermo,

Can you indent the <param/> with two spaces, please? It's a detail, but it makes things easier to read in the longer run. Thanks!

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 339156 [details] [diff] [review]
New patch

r- per stas, clearing approval flag.

Comment 14

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch with Staś recommendation

New patch with Staś recommendation

Comment 15

[Staś Małolepszy :stas]

Comment on attachment 339440 [details] [diff] [review]
Patch with Staś recommendation 

r=me. Thanks :)

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 339440 [details] [diff] [review]
Patch with Staś recommendation 

a=me for 3.0.3. Please land this with a check-in comment referencing this bug
and my approval and stas' review.

Please use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and
testing.

Comment 17

[Guillermo López :willyaranda (probably SLOW response)]

guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/searchplugins$ cvs commit -m "Change eBay-es.xml searchplugin due request in bug 452533. a=Pike , r=stas. Made by Guillermo"l searchplugin due request in bug 452533. a=Pikecvs commit: Examining .
Checking in eBay-es.xml;
/l10n/l10n/es-ES/browser/searchplugins/eBay-es.xml,v  <--  eBay-es.xml
new revision: 1.3; previous revision: 1.2
done
guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/searchplugins$ 

Checked in.

Please Ricardo, change keywords because I can't.

Commited and pushed on hg:

http://hg.mozilla.org/l10n-central/es-ES/rev/d4478e3390ea

Comment 18

[RickieES aka Ricardo Palomares]

(In reply to comment #17)
> Checked in.
> 
> Please Ricardo, change keywords because I can't.
> 
> Commited and pushed on hg:
> 
> http://hg.mozilla.org/l10n-central/es-ES/rev/d4478e3390ea


I guess you couldn't change keywords because you weren't the asignee for the bug. I've done it for you and reassigned the bug to you.

Comment 19

[RickieES aka Ricardo Palomares]

Verified with a 3.0.4pre nightly and a 3.1b2 nightly. The suggestions feature only works in Firefox 3.1, but both returns appropiate results to the search parameters.