Closed Bug 452536 Opened 14 years ago Closed 14 years ago

Change the url for eBay search plug-in for (en-US)

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.1b1

People

(Reporter: mic, Assigned: stas)

Details

(Keywords: verified1.9.0.4)

Attachments

(2 files)

please change the url for the eBay search plug in per a request from eBay due
to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/711-47294-18009-3/4?satitle={searchTerms}

i have tested the url and it seems to redirect fine

this will require a patch
The mycroft project on mozdev maintains this if I remember right.
http://mycroft.mozdev.org/ebay-search-plugins.html
Find the right one and press "Review".

The search location is today is allow:
http://mycroft.mozdev.org/installos.php/24983/ebay-com-worldwide.xml
You remember wrong, we maintain our search plugins in our cvs repo, and they don't have any affiliation with the mycroft ones.

Actually, the mycroft plugin should probably not use the URL we use, but Mic and Seth should verify that with ebay.
Well seeing as that looks like a Mozilla supporting affiliate url, no the Mycroft Project won't be using it.

Is this really an eBay request??
(obviously I'm not about to complain if you want to increase your cash flow in  a way that I already do but I'm surprised if you're going to slip it in under the radar.)

(And Jesper, that wouldn't be the right plugin anyway)
this is not meant to be "slipped in"
this request from ebay is due to some server side changes they have made on their side to be sure to send users to the right country service. we have thoroughly investigated this from a technical standpoint as well as user experience and privacy of data etc
hope that helps clarify the rationale for this request from comment #3
Apologies for potentially incorrect accusations.
Would be grateful if you could confirm whether or not that is a revenue generating url though.
(In reply to comment #5)
> Apologies for potentially incorrect accusations.
> Would be grateful if you could confirm whether or not that is a revenue
> generating url though.

We're not making statements like that in bugs.

If you're interested in a statement, I suggest contacting press@mozilla.com.
Attachment #338683 - Flags: review?(l10n)
Attachment #338683 - Flags: approval1.9.0.3?
Comment on attachment 338683 [details] [diff] [review]
New URL, only one parameter (satitle)
[Checkin: Comment 12]

r=me.
Attachment #338683 - Flags: review?(l10n) → review+
Attachment #338683 - Flags: approval1.9.0.3?
Same patch for CVS trunk. Requesting approval1.9.0.3.
Attachment #339413 - Flags: review?(l10n)
Attachment #339413 - Flags: approval1.9.0.3?
Comment on attachment 339413 [details] [diff] [review]
Patch for CVS trunk

I don't think we need seperate patches for cvs in general. hg patches should generally apply fine with the right -p1 or -p2.
Attachment #339413 - Flags: review?(l10n) → review+
Thanks Axel, I'll keep this in mind.

I think this is a checkin-needed for hg for now.
Keywords: checkin-needed
Comment on attachment 338683 [details] [diff] [review]
New URL, only one parameter (satitle)
[Checkin: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/c17e3c090e02
Attachment #338683 - Attachment description: New URL, only one parameter (satitle) → New URL, only one parameter (satitle) [Checkin: Comment 12]
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [ToDo: 1.9.0 branch]
Target Milestone: --- → Firefox 3.1b1
Version: 3.0 Branch → Trunk
Assignee: nobody → stas
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20081006 Minefield/3.1b1pre.  ebay search goes to rover.ebay.com
Status: RESOLVED → VERIFIED
Comment on attachment 339413 [details] [diff] [review]
Patch for CVS trunk

Approved for 1.9.0.4, a=dveditz for release-drivers
Attachment #339413 - Flags: approval1.9.0.4? → approval1.9.0.4+
This needs to land by tomorrow, Friday, October 24 at 11:59pm if it's going to make this cycle.
I don't have commit rights to land this patch on CVS, can someone please help out? Thanks.
Keywords: checkin-needed
browser/locales/en-US/searchplugins/eBay.xml 1.5
Whiteboard: [ToDo: 1.9.0 branch]
Thanks so much!
Verified for 1.9.0.4 with  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4pre) Gecko/2008102706 GranParadiso/3.0.4pre.
You need to log in before you can comment on or make changes to this bug.