452566 - navigator.geolocation optional parameters on getCurrentPosition and watchPosition are not optional

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[DivineGod]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080827020629 Minefield/3.1a2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080827020629 Minefield/3.1a2pre

When trying to use the navigator.geolocation features the spec as given by w3c is not implemented correctly.

navigator.geolocation.getCurrentPosition takes three parameters, two of which are optional in the spec, when using them in firefox, they are not optional.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

A minimal testcase would be great here.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: untested patch

now I need to figure out how to use geolocation :)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: with tests

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 335893 [details] [diff] [review]
with tests

didn't know about that idl flag.  cool.

could you rename "test_geolocation_api" to "test_optional_api_params"?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: test_optional_api_params