Improve CSE to recognize commutative instructions

VERIFIED WONTFIX

Status

Tamarin
Tracing Virtual Machine
--
enhancement
VERIFIED WONTFIX
10 years ago
8 years ago

People

(Reporter: Peter Varga, Unassigned)

Tracking

unspecified
x86
Linux
Bug Flags:
in-testsuite -
flashplayer-triage +

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hu; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: tamarin-tracing/5f35ec56a98a

This patch modifies the CSE filter to be able to eliminate commutative instructions with different ordered operands. It is a small modification and does not show any measurable difference on the sunspider tests but it helps the CSE filter to remove some unnecessary instructions. In the performance tests it can eliminate 7 LIR instructions in 3 files. It is not so much, but more than nothing.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Comment 1

10 years ago
Created attachment 335852 [details] [diff] [review]
Commutative instructions

Updated

10 years ago
Flags: in-testsuite-
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

Updated

10 years ago
Attachment #335852 - Flags: review?(edwsmith)

Updated

10 years ago
Attachment #335852 - Flags: review?(edwsmith) → review-

Comment 2

10 years ago
Comment on attachment 335852 [details] [diff] [review]
Commutative instructions

Needs testing and rebasing (R-), but this is a good change that we do want so lets keep it near the top of our lists.

Comment 3

10 years ago
rebasing & testing has been done, the improvements are so minor it doesn't seem worthwhile.  reopen if a more comprehensive patch with better results comes to light.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WONTFIX

Updated

9 years ago
Status: RESOLVED → VERIFIED

Updated

8 years ago
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.