Closed Bug 452588 Opened 14 years ago Closed 14 years ago

Make Tracemonkey work on Solaris x86 with Sun Studio 12

Categories

(Core :: JavaScript Engine, defect)

x86
OpenSolaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

Attachments

(1 file, 1 obsolete file)

 
Depends on: 452589
Attached patch patch (obsolete) — Splinter Review
Patch of Bug 452589 is a requirement of this patch.

Changes:
Makefile.in : Use lowe opt level for LIR.cpp to workaround a bug
jstracer.cpp : include alloca.h; js_CheckForSSE2() inline asm "pusha" confused Sun Studio
LIR.h : We have to use exactly "signed int" to have signed bitfield
Nativei386.cpp : mprotect prototype difference; a workaround for 16-byte alignment
avmplus.h : implement rdtsc(); munmap prototype difference

We may merge the inline asm of rdtsc() and js_CheckForSSE2() with GCC implementation.
But it's not a big deal.
Attachment #336638 - Flags: review?(danderson)
Attached patch patchSplinter Review
repost to fix tab and whitespaces
Attachment #336638 - Attachment is obsolete: true
Attachment #336639 - Flags: review?(danderson)
Attachment #336638 - Flags: review?(danderson)
Attachment #336639 - Flags: review?(danderson) → review+
Comment on attachment 336639 [details] [diff] [review]
patch

Will merge and push this shortly.
Pushed change to the tracemonkey branch: http://hg.mozilla.org/tracemonkey/rev/f821f6cfe043

If you could, please verify that this looks okay as I had to merge some of it manually.
Closing from m-c merge last night.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
+	$(REPORT_BUILD)
+	@$(MAKE_DEPS_AUTO_CXX)
+	$(CXX) -o $@ -c $(patsubst -xO%,-xO2,$(COMPILE_CFLAGS)) $<

These three lines should be started with "\t" instead of " ".
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.