452588 - Make Tracemonkey work on Solaris x86 with Sun Studio 12

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ginn Chen]

Comment 1

[Ginn Chen]

Attachment: patch

Patch of Bug 452589 is a requirement of this patch.

Changes:
Makefile.in : Use lowe opt level for LIR.cpp to workaround a bug
jstracer.cpp : include alloca.h; js_CheckForSSE2() inline asm "pusha" confused Sun Studio
LIR.h : We have to use exactly "signed int" to have signed bitfield
Nativei386.cpp : mprotect prototype difference; a workaround for 16-byte alignment
avmplus.h : implement rdtsc(); munmap prototype difference

We may merge the inline asm of rdtsc() and js_CheckForSSE2() with GCC implementation.
But it's not a big deal.

Comment 2

[Ginn Chen]

Attachment: patch

repost to fix tab and whitespaces

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 336639 [details] [diff] [review]
patch

Will merge and push this shortly.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Pushed change to the tracemonkey branch: http://hg.mozilla.org/tracemonkey/rev/f821f6cfe043

If you could, please verify that this looks okay as I had to merge some of it manually.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Closing from m-c merge last night.

Comment 6

[Boying Lu]

+	$(REPORT_BUILD)
+	@$(MAKE_DEPS_AUTO_CXX)
+	$(CXX) -o $@ -c $(patsubst -xO%,-xO2,$(COMPILE_CFLAGS)) $<

These three lines should be started with "\t" instead of " ".

Comment 7

[Ginn Chen]

Bustage fix pushed
http://hg.mozilla.org/mozilla-central/rev/475542ec5079
http://hg.mozilla.org/tracemonkey/rev/2dd5043740fc