Closed
Bug 452589
Opened 16 years ago
Closed 16 years ago
Rename AVMPLUS_LINUX to AVMPLUS_UNIX
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
Attachments
(1 file, 3 obsolete files)
|
7.34 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Then it will be consistent with Tamarin. And I can avoid using #if defined(AVMPLUS_LINUX) || defined(AVMPLUS_SOLARIS) or -DAVMPLUS_LINUX on Solaris platform, it's not reasonable.
Comment on attachment 335864 [details] [diff] [review] patch Should the Darwin case define AVMPLUS_UNIX? Are all of the behaviours conditioned on AVMPLUS_LINUX in place on other Unixes? (I'm thinking specifically of the ARM cases.)
Attachment #335864 -
Flags: review?(shaver)
Attachment #335864 -
Attachment is obsolete: true
Attachment #336031 -
Flags: review?(shaver)
fix a typo
Attachment #336031 -
Attachment is obsolete: true
Attachment #336036 -
Flags: review?(shaver)
Attachment #336031 -
Flags: review?(shaver)
Attachment #336036 -
Flags: review?(shaver) → review?(danderson)
Attachment #336036 -
Attachment is obsolete: true
Attachment #336630 -
Flags: review?
Attachment #336036 -
Flags: review?(danderson)
Attachment #336630 -
Flags: review? → review?(danderson)
|
||
Updated•16 years ago
|
Attachment #336630 -
Flags: review?(danderson) → review+
Comment on attachment 336630 [details] [diff] [review] patch v2 update to trunk I'm going to push this shortly with minor changes. I kept AVMPLUS_LINUX around for the ARM stuff.
Pushed to tracemonkey repository as changeset eaca60552fb8. Note that the SunOS files in config/ are unchanged, so shell builds won't have tracing (Makefile.ref is responsible for using those). Will close this once we merge with mozilla-central.
Closing from m-c merge last night.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•