Closed Bug 452657 Opened 12 years ago Closed 12 years ago

Remove richview from toolkit

Categories

(Toolkit :: Application Update, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

Attachments

(1 file)

The richview is no longer used and should be removed. Filing under app update since it lives under toolkit/mozapps/shared and was never an official toolkit widget.
It appears the itemSelected.png image that was created for the richview is used for other purposes by console.css
http://mxr.mozilla.org/mozilla-central/search?string=itemSelected.png&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Attached patch patch rev1Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #335941 - Flags: review?(dtownsend)
Attachment #335941 - Flags: review?(dtownsend) → review+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/6fd9393f7f1c47a7d0c58c09b82d2710789975a1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
mozilla-central
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080902010659 Minefield/3.1b1pre

These exist. Is this all right?
http://hg.mozilla.org/mozilla-central/diff/6fd9393f7f1c/toolkit/themes/winstripe/mozapps/jar.mn
chrome://mozapps/skin/shared/itemFader.png
chrome://mozapps/skin/shared/itemSelected.png
chrome://mozapps/skin/shared/richview.css
chrome://mozapps/skin/shared/richview.xml
chrome://mozapps/skin/shared/viewFader.png
I haven't checked a nightly but the following doesn't show the shared directory anymore
http://hg.mozilla.org/mozilla-central/file/6fd9393f7f1c/toolkit/themes/winstripe/mozapps/
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080902033133 Minefield/3.1b1pre

Doesn't have those files... you were most likely using a non nightly build which wasn't clobbered so it contained those files.
Well... nightly build doesn't have those files.
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-09-02-03-mozilla-central/

Tinderbox build still have those files (20080902110200).
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/

I was confused.
You need to log in before you can comment on or make changes to this bug.