452674 - nanojit assertions defy automated testing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

These problems make it very difficult to automate looking for assertion bugs:
* The actual error message goes to stdout rather than stderr.
* With NanoAssertMsg, the condition and line number and even the text "Assertion failed" are missing. The only hint that an assertion failed is the generic message in stderr.

These problems merely cause confusion:
* With NanoAssert, two extra sets of parens are shown.
* The second message is unnecessary and confusing: it makes it seem like the first message was not a fatal assertion.  The second message seems to come from DebugBreak->AvmAssert->assert (nanojit/avmplus.h).
* The filename is in quotes, which breaks pasting the filename along with the line number into a text editor.


Example 1:
NanoAssert(rmask(rr)&FpRegs);

stdout: Assertion failed: "((rmask(rr)&FpRegs))" ("nanojit/Nativei386.cpp":605)
stderr: nanojit/Nativei386.cpp:605: failed assertion `0'

Example 2:
NanoAssertMsg(0, "need a way to EOT now, since this is trace end");

stdout: need a way to EOT now, since this is trace end
stderr: nanojit/LIR.cpp:868: failed assertion `0'

Comment 1

[Jesse Ruderman]

Attachment: patch

Fixes all the complaints in comment 0.