Closed
Bug 452677
Opened 17 years ago
Closed 17 years ago
Control characters in WebSearchField are replaced with nothing, rather than a space
Categories
(Camino Graveyard :: Toolbars & Menus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)
References
Details
Attachments
(1 file)
|
1006 bytes,
patch
|
chris
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
Bug 391087 comment 12 notes "newlines pasted into the search field should probably become spaces". I agree. Right now they're being turned into nothing, which leads to problems when copying and pasting text there. For example, one might wish to copy "some\rtext" and search for "some text", but right now you'd get "sometext" instead.
This is a one-line change to WebSearchField.mm that requires bug 411165's NSString+Utils changes to work properly.
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 335955 [details] [diff] [review]
fix v1.0
This is pretty redonkulous, so requesting r/sr together.
Attachment #335955 -
Flags: superreview?(mikepinkerton)
Attachment #335955 -
Flags: review?(trendyhendy2000)
|
||
Updated•17 years ago
|
Attachment #335955 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 335955 [details] [diff] [review]
fix v1.0
sr=pink. make it so.
|
||
Updated•17 years ago
|
Attachment #335955 -
Flags: review?(trendyhendy2000) → review+
Landed on cvs trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•