Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dvander, Assigned: brendan)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2936	        JS_ASSERT(entry->kpc == (jsbytecode*) atoms[GET_INDEX(cx->fp->regs->pc)]);
(gdb) l
2931	                                      "shape");
2932	            guard(true, addName(lir->ins2i(LIR_eq, shape_ins, entry->kshape), "guard(kshape)"),
2933	                  MISMATCH_EXIT);
2934	        }
2935	    } else {
2936	        JS_ASSERT(entry->kpc == (jsbytecode*) atoms[GET_INDEX(cx->fp->regs->pc)]);
2937	        JS_ASSERT(entry->kshape == jsuword(aobj));
2938	        if (aobj != globalObj) {
2939	            guard(true, addName(lir->ins2i(LIR_eq, obj_ins, entry->kshape), "guard(kobj)"),
2940	                  MISMATCH_EXIT);
(gdb) p *entry
$6 = {
  kpc = 0x1268448c "", 
  kshape = 309585280, 
  vcap = 2865410, 
  vword = 11875922
}
(gdb) p cx.fp.regs.pc
$7 = (jsbytecode *) 0xa742eb "?"
(gdb) p (JSOp)*cx.fp.regs.pc
$8 = JSOP_GETLOCALPROP
Note: not just in chrome.  Hit it in gmail too.
(Assignee)

Comment 2

10 years ago
Created attachment 335978 [details] [diff] [review]
fix, plus cleanups i had in my tm tree

Have to run home -- David, could you please review and, if good, land in the tracemonkey repo? Thanks.

/be
Attachment #335978 - Flags: review?(danderson)
(Assignee)

Comment 3

10 years ago
Test as well as review, of course ;-).

/be
Still hitting this unfortunately:

#1  0x002c95a4 in TraceRecorder::test_property_cache (this=0x17f91220, obj=0x17286740, obj_ins=0x15273060, obj2=@0xbfff82a0, pcval=@0xbfff829c) at /Users/dvander/mozilla/debugmonkey/js/src/jstracer.cpp:2939
2939	        JS_ASSERT(entry->kpc == (jsbytecode*) atoms[index]);
(gdb) print index
$2 = 1
(gdb) print atoms[index]
$3 = (JSAtom *) 0x172642e4
(gdb) print entry->kpc
$4 = (jsbytecode *) 0x1722b424 "?p?\027\003"
(gdb) print/x format
$5 = 0xa8
(gdb) print pcoff
$6 = 0
(gdb) print (JSOp)*cx->fp->regs->pc
$7 = JSOP_GETLOCALPROP
(Assignee)

Comment 5

10 years ago
Created attachment 336006 [details] [diff] [review]
JOF_VARPROP is a mode, not an opcode format type.

David, try this -- should work.

/be
Attachment #335978 - Attachment is obsolete: true
Attachment #336006 - Flags: review?(danderson)
Attachment #335978 - Flags: review?(danderson)
Comment on attachment 336006 [details] [diff] [review]
JOF_VARPROP is a mode, not an opcode format type.

Tested to work now.
Attachment #336006 - Flags: review?(danderson) → review+
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
Version: 1.9.0 Branch → Trunk

Updated

10 years ago
Depends on: 488607
You need to log in before you can comment on or make changes to this bug.