452739 - "$ is not defined" error on category landing pages; stylesheets and elements missing

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:72

Error: $ is not defined
Source File: https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:72
Line: 101

(which, according to the Error Console, is:)

$("#lver-td input").remove();

Also, the page is missing its stylesheet.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks like something went awry when running the build script we have, because the output is:

<link rel="stylesheet" type="text/css" href="/css/style.min.css?CSS_REVISION" media="all" />

<snip>

<script type="text/javascript" src="/js/jquery.addons.min.js?JS_REVISION"></script>

Both CSS_REVISION and JS_REVISION are raw, and should be numbers, instead.

Comment 2

[Fred Wenzel [:wenzel]]

Fatal error: Call to undefined method ImageComponent::urlForAddonIcon() in /Users/fred/dev/addons/site/app/views/addons/category_landing.thtml on line 101

Introduced by fligtar in r17880.

Comment 3

[Fred Wenzel [:wenzel]]

By the way I have a patch ready to commit, but it's blocked on bug 452789.

Comment 4

[Fred Wenzel [:wenzel]]

Fixed in r18009.

PS: It weirds me out how I have to click twice to mark a bug fixed, then scroll to the bottom, then click commit. :(((

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Fred!