452857 - Could not access places.sqlite from XUL due to NS_ERROR_FILE_IS_LOCKED.

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008082906 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3pre) Gecko/2008082906 Firefox/3.0.1

The following errors are given and cannot access places.sqlite from XUL

Error in opening file places.sqlite - perhaps, this is not an sqlite db file
Exception Name: NS_ERROR_FILE_IS_LOCKED
Exception Message: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [mozIStorageService.openDatabase]

Reproducible: Sometimes

Steps to Reproduce:
1.Install SQLite Manager 0.3.7( https://addons.mozilla.org/en-US/firefox/addon/5817 )
2.Install XUL/Migemo 0.10.6( https://addons.mozilla.org/en-US/firefox/addon/5239 )

3.Open SQLite Manager
4.Open places.sqlite database

5.Open Bookmarks Sidebar
6.Search bookmarks using Migemo

7.Repeat step 3,4,5,6 several times
Actual Results:  
The following errors are given and cannot access places.sqlite from XUL

Error in opening file places.sqlite - perhaps, this is not an sqlite db file
Exception Name: NS_ERROR_FILE_IS_LOCKED
Exception Message: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [mozIStorageService.openDatabase]


Expected Results:  
No error and access the database from XUL.

Comment 1

[Alice0775 White]

There is no error In Firefox 3.0.1 and Gran Paradiso3.0.2pre.
The error is occur in Minefield 3.1a2pre～) only.

Comment 2

[Shawn Wilsher :sdwilsh]

This was done for performance benefits (~7% faster location bar queries for instance).

Consumers who need to use the database connection should QueryInterface nsINavHistoryService to nsPIPlacesDatabase (and should only be doing read-only work with it).

Comment 3

[chiisaitsu]

Does this not also affect the XUL storage template builder?  I'm no Firefox dev, but it looks like nsXULTemplateQueryProcessorStorage::GetDatasource is still blindly OpenDatabase'ing datasources, when if I hear you right everyone should now be sharing the Places DB connection by QI'ing on nsPIPlacesDatabase.

My extension has a template with datasources="profile:places.sqlite".  The template works on the 3.1a2pre nightly of 2008-08-12 but not on the 3.1a2pre nightly of 2008-08-29 -- no nodes are generated.  Browsing the mozilla-central Mercurial, I see that this is about the same time that nsPIPlacesDatabase was introduced.

I'll attach a minimal test case.

Comment 4

[chiisaitsu]

Attachment: Test case re: comment 3

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv