Closed Bug 452912 Opened 12 years ago Closed 11 years ago

Optimize Windows x64 build for javascript engine

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v1 for Win64 x64 (obsolete) — Splinter Review
jsbit and jslock has no optimization for x64 Windows.

- MSVC for x64 has no inline assembler.  But x64 has _InterlockedCompareExchange64 for exchange compare.
- MSVC for x64 is version 14 or later.
Attachment #336164 - Flags: superreview?(brendan)
Attachment #336164 - Flags: review?(brendan)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 336164 [details] [diff] [review]
patch v1 for Win64 x64

We don't use SR in js/src.

David, can you look? Or punt to crowder if he is game -- he's Windows enabled, if not Windows 64-bit enabled (who has such a system at Mozilla, anyway?).

/be
Attachment #336164 - Flags: superreview?(brendan)
Attachment #336164 - Flags: review?(danderson)
Attachment #336164 - Flags: review?(brendan)
OS: Windows Vista → Windows XP
Hardware: x86 → x86_64
Attached patch patch v1.1Splinter Review
sync with latest tree
Attachment #336164 - Attachment is obsolete: true
Attachment #390619 - Flags: review?
Attachment #336164 - Flags: review?(dvander)
Attachment #390619 - Flags: review? → review?(dvander)
Attachment #390619 - Flags: review?(dvander) → review+
http://hg.mozilla.org/mozilla-central/rev/2759d33c9aa9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.