Open Bug 452924 Opened 16 years ago Updated 2 years ago

Lines count change after downloading offline an NNTP message

Categories

(MailNews Core :: Networking: NNTP, defect)

Product:
MailNews Core
Component:
Networking: NNTP
Version:
1.9.1 Branch
Type:
defect

Tracking

(Not tracked)

People

(Reporter: wodny, Unassigned)

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: version 2.0.0.16 (20080724)

Lines count change after downloading offline an NNTP message.

The new value (includes header lines) is inconsistent with the old value, which is from XOVER command and includes only body lines.

It affects 3.0a2 as well.

Reproducible: Always

Steps to Reproduce:
1. Open a newsgroup
2. Enable lines count column
3. Right click on a "fresh"/unread message
4. Click "Get Selected Messages"
Actual Results:  
Lines count changed

Expected Results:  
Lines count shouldn't change (I suppose)

Here:
https://bugzilla.mozilla.org/show_bug.cgi?id=249841
I submitted a draft of a patch for a bug which is associated with this new one
I suppose things have not changed with 3.0b2 ? Can you add a nntp log file (described at https://wiki.mozilla.org/MailNews:Logging) to this bug ?
Component: General → Networking: News
Product: Thunderbird → MailNews Core
QA Contact: general → networking.news
Version: unspecified → 1.9.1 Branch
It still is present in 3.0b2.

LOG WITH COMMENTS:
==================
Entering newsgroup

-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) fullPath = /pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) fullPath = /pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) m_messageID = (null)
-1227630768[b6a10060]: (b51fa650) group = pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) commandSpecificData = (null)
-1227630768[b6a10060]: (b51fa650) m_key = -1
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND
-1227630768[b6a10060]: (b51fa650) Sending: GROUP pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_RESPONSE
-1227630768[b6a10060]: (b51fa650) Receiving: 211 19101 1417838 1437451 pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
-1227630768[b6a10060]: (b51fa650) Next state: SETUP_NEWS_STREAM
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XOVER_BEGIN
-1227630768[b6a10060]: (b51fa650) SetCurrentGroup to pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_FIGURE_NEXT_CHUNK

'Download message' prompt came up here. Chosing to download 1 message header.

-1227630768[b6a10060]: (b51fa650) Chunk will be (1437451-1437451)
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XOVER_SEND
-1227630768[b6a10060]: (b51fa650) Sending: XOVER 1437451-1437451
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_RESPONSE
-1227630768[b6a10060]: (b51fa650) Receiving: 224 1437451-1437451 fields follow
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XOVER_RESPONSE
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XOVER
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XOVER
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_XHDR_SEND
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_FIGURE_NEXT_CHUNK
-1227630768[b6a10060]: (b51fa650) add to known articles:  1437451 - 1437451
-1227630768[b6a10060]: (b51fa650) Next state: NEWS_PROCESS_XOVER
-1227630768[b6a10060]: (b51fa650) Next state: NEWS_DONE
-1227630768[b6a10060]: (b51fa650) Next state: NEWS_FREE
-1227630768[b6a10060]: (b51fa650) CleanupAfterRunningUrl()
-1227630768[b6a10060]: (b51fa650) setting busy to 0

1 message appeared on the list. Selecting message...

-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) original message spec = news-message://news.gazeta.pl/pl.comp.pecet#1437451
-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) original message spec = news-message://news.gazeta.pl/pl.comp.pecet#1437451
-1227630768[b6a10060]: (b51fa650) m_messageID = (null)
-1227630768[b6a10060]: (b51fa650) group = 
-1227630768[b6a10060]: (b51fa650) commandSpecificData = (null)
-1227630768[b6a10060]: (b51fa650) m_key = 1437451
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND
-1227630768[b6a10060]: (b51fa650) current group = pl.comp.pecet, desired group = pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_SEND_ARTICLE_NUMBER
-1227630768[b6a10060]: (b51fa650) Sending: ARTICLE 1437451
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_RESPONSE
-1227630768[b6a10060]: (b51fa650) Receiving: 220 1437451 <gpm8uu$1v8$1@news.onet.pl> article
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
-1227630768[b6a10060]: (b51fa650) Next state: SETUP_NEWS_STREAM
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_BEGIN_ARTICLE
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_READ_ARTICLE

72 same lines as above

-1227630768[b6a10060]: (b51fa650) Next state: NEWS_DONE
-1227630768[b6a10060]: (b51fa650) Next state: NEWS_FREE
-1227630768[b6a10060]: (b51fa650) CleanupAfterRunningUrl()
-1227630768[b6a10060]: (b51fa650) setting busy to 0

Executing `File > Offline > Get Selected Messages`...

-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) original message spec = news-message://news.gazeta.pl/pl.comp.pecet#1437451
-1227630768[b6a10060]: (b51fa650) setting busy to 1
-1227630768[b6a10060]: (b51fa650) ParseURL
-1227630768[b6a10060]: (b51fa650) original message spec = news-message://news.gazeta.pl/pl.comp.pecet#1437451
-1227630768[b6a10060]: (b51fa650) m_messageID = (null)
-1227630768[b6a10060]: (b51fa650) group = 
-1227630768[b6a10060]: (b51fa650) commandSpecificData = (null)
-1227630768[b6a10060]: (b51fa650) m_key = 1437451
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND
-1227630768[b6a10060]: (b51fa650) current group = pl.comp.pecet, desired group = pl.comp.pecet
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_SEND_ARTICLE_NUMBER
-1227630768[b6a10060]: (b51fa650) Sending: ARTICLE 1437451
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_RESPONSE
-1227630768[b6a10060]: (b51fa650) Receiving: 220 1437451 <gpm8uu$1v8$1@news.onet.pl> article
-1227630768[b6a10060]: (b51fa650) Next state: SEND_FIRST_NNTP_COMMAND_RESPONSE
-1227630768[b6a10060]: (b51fa650) Next state: SETUP_NEWS_STREAM
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_BEGIN_ARTICLE
-1227630768[b6a10060]: (b51fa650) Next state: NNTP_READ_ARTICLE

72 lines same as above

-1227630768[b6a10060]: (b51fa650) Next state: NEWS_DONE
-1227630768[b6a10060]: (b51fa650) Next state: NEWS_FREE
-1227630768[b6a10060]: (b51fa650) CleanupAfterRunningUrl()
-1227630768[b6a10060]: (b51fa650) setting busy to 0

Line count changed from 52 to 73.

===========
END OF LOG.
===========


The path that leads to this situation is visible in the patch provided here  https://bugzilla.mozilla.org/show_bug.cgi?id=249841
so, this is not a regression?
Assuming we go with my fix on bug 249841, this mainly becomes a cosmetic problem of sorts.  (The line count will change, but it should not cause misbehavior by Thunderbird itself.)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.