452928 - installer warnings in win builds log

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Vlado Valastiak [:wladow]]

There are these warnings in build log of win builds:
warning: LangString "SUMMARY_REBOOT_REQUIRED_INSTALL" is not set in language table of language baseLocale
warning: LangString "SUMMARY_MAKE_DEFAULT" is not set in language table of language baseLocale
warning: LangString "MUI_TEXT_FINISH_SHOWREADME" is not set in language table of language baseLocale

Those strings are implemented in /toolkit/mozapps/installer/ and used in Firefox, but not yet in SeaMonkey.

SUMMARY_REBOOT_REQUIRED_INSTALL
- introduced in Bug 398036 – Add file in use install support
- will be added in Bug 449423  
 
SUMMARY_MAKE_DEFAULT
- introduced in Bug 392137 - Retention: take over user defaults during install on Win32

MUI_TEXT_FINISH_SHOWREADME - the only occurence is macro commented out in http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/windows/nsis/common.nsh#272
Maybe we should remove it? CCing Rob Strong.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: toolkit patch rev1

I'm going to verify a few things before requesting review

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: suite patch rev1

same here

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: suite patch rev2

This patch takes care of the warnings. These warnings don't cause any harm so I'm not going to take this bug and if bug 449423 takes on the additions that were made to Firefox then this bug will be fixed by it. If someone wants to take this on please do so.

Comment 4

[Frank Wein [:mcsmurf]]

uninstaller.nsi part of this patch has been included in fix for Bug 453797, installer.nsi part not yet.

Comment 5

[Robert Kaiser]

What's the status here? Is this resolved?

Comment 6

[Robert Strong (they/them - no direct email)]

Just looked at the logs on
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1242025200.1242031799.9195.gz&fulltext=1

and there are no NSIS warnings in the log

resolving -> wfm