Style security bugs to give them a distinctive look, e.g. a background color

VERIFIED FIXED

Status

()

bugzilla.mozilla.org
General
--
enhancement
VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: dveditz, Assigned: johnath)

Tracking

Details

(Whiteboard: [sg:want])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Because Mozilla developers deal with many bugs it gets difficult to keep track of which are security-related and which aren't. This is important because in many cases we discuss these bugs in open meeting settings. It would be helpful to give security bugs a distinctive look.

For my own purposes I care the most about bugs in the "core-security" group, but this is probably useful for all security-related group, maybe even every private group. I personally find it handy to use different background colors for different groups, but using the same marking for all groups would be perfectly acceptable since the important thing is a visible reminder that the bug should be treated with care.

Personally I've used color since it's eye-catching, but I'd be just as happy with some sort of ghosted background "watermark" (a lock?) if it was visible enough. In my own experiments, though, it was hard to make the image light enough to not interfere with the page text while dark enough to be noticed.

If you don't want to call out individual groups then you want a fallback that uses the selector "body[class*=bz_group_]". I may have picked colors that are too dark for some people (especially the fall-back blue), but here's what I've used in my userContent.css:

  /* colorize bugs in various groups */
  body[class*=bz_group_] {
    background-color: #eeeeff !important;
  }

  body.bz_group_webtools-security,
  body.bz_group_bugzilla-security {
    background-color: #ffeeee !important;
  }

  body.bz_group_client-services-security {
    background-color: #ffff80 !important;
  }

  body.bz_group_core-security {
    background-color: #ffe0b0 !important;
  }

If you only have a single color I'd vote for a yellow or orange like I've used for core-security and client-services-security.
(Assignee)

Comment 1

10 years ago
This is something that has come up a lot in my own discussions as well, and I've restored to my own userContent hacks that are strikingly similar to Dan's.  I appreciate that this wouldn't likely be a candidate for uplift to the bugzilla project in general since it's specific to our groups, but if someone points me to the appropriate repository, I'm happy to convert dan's rules into a patch.  :)
(Assignee)

Comment 3

10 years ago
Created attachment 336851 [details] [diff] [review]
Dan's coloring applied to custom/show_bug.css

Straight injection of Dan's colouring into custom/show_bug.css - I don't have a living bugzilla instance to test against, but the rules do behave as advertised when injected into bugzilla via firebug
Attachment #336851 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #336851 - Flags: review? → review?(justdave)
(Reporter)

Updated

10 years ago
Whiteboard: [sg:want]
Attachment #336851 - Flags: review?(justdave) → review-
Comment on attachment 336851 [details] [diff] [review]
Dan's coloring applied to custom/show_bug.css

Can you add websites-security, too? We have five security groups. :)
(Assignee)

Comment 5

10 years ago
Created attachment 336887 [details] [diff] [review]
reed loden is my master

Add websites-security in with webtools-security and bugzilla-security
Attachment #336851 - Attachment is obsolete: true
Attachment #336887 - Flags: review?(justdave)
(Assignee)

Updated

10 years ago
Attachment #336887 - Flags: review?(justdave) → review?(reed)
(Assignee)

Comment 6

10 years ago
Reed - should I choose a different reviewer here?  I know you're a busy guy, but this would still be handy.

Comment 7

10 years ago
Two things:

1) Before implementing this, you should be aware of bug 425668 comment 3.

2) I already have my own rules for security groups in my userContent.css file. Are my rules going to be overriden by those defined here as they use !important too? If that's the case, I would be very irritated. :-/ I hope Fx3 gives higher priority to userContent.css anyway.
(Reporter)

Comment 8

10 years ago
1) This will still help without a fix for bug 425668, and will in fact raise the visibility of that bug so maybe it'll get fixed.

2) userContent should win in any case, but there shouldn't be any real reason for these rules to need !important when used on the site.
Assignee: nobody → johnath
Status: NEW → ASSIGNED
Comment on attachment 336887 [details] [diff] [review]
reed loden is my master

r=me
Attachment #336887 - Flags: review?(reed) → review+
modified skins/custom/show_bug.css                                   
Committed revision 6179.
All changes applied successfully.

Expect propagation within the next few minutes.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Changes are live after a shift+reload. Thanks Reed!

I'll file a new bug for the non-transparent background image at the top.
Status: RESOLVED → VERIFIED
Depends on: 477970
(Reporter)

Comment 13

9 years ago
Some people have complained about my color choices, which is fine since they were only offered up as an example. ss suggested a border instead. I don't like it as much because it's not as visible, but if people feel strongly about their black on white contrast for reading it'd still work ok. something like

  body[class*=bz_group_] {
    border: solid 20px red;
  }

No real need to distinguish different groups for most people, the important distinction is between private and public. For people like me with access to too many groups there's always userContent.css.
I kind of think something bluish fits in better, but I'm not 100% sure.  It's also possible "fitting in" is a non-goal, even an anti-goal.  I fiddled for a few minutes, and the following might work for me:

javascript:alert(document.body.style.backgroundColor="hsl(215, 20%, 85%)")

Then again, I have a very hard time considering any color in its entirety here so long as bug 477970 exists, so I don't even know whether I truly like this color or not.

In any case I don't care enough to really complain, just throwing out another suggestion for anyone who's really interested in seeing  different color in place.
How about just an eye-catching strip down the side?

Quick mockup: http://people.mozilla.com/~dolske/tmp/secstyle.html
(Assignee)

Comment 16

9 years ago
Dolske - I think with some padding to offset it from the bug content, and maybe about 20% less OMG-eye-catching, this could work really well. Arguably better than the background colour, since it is a near-constant reminder that you are in a special place. Follow-up bug?  Should get beltzner to comment too, since he was one of the ones that wanted this feature originally, iirc?
Blocks: 478980
No longer blocks: 478980
(Reporter)

Updated

9 years ago
Blocks: 483012
(Reporter)

Comment 17

9 years ago
Spun off bug 483012 to cover the suggestion in comment 15.
Component: Bugzilla: Other b.m.o Issues → General
Product: mozilla.org → bugzilla.mozilla.org
You need to log in before you can comment on or make changes to this bug.