Closed Bug 453110 Opened 16 years ago Closed 16 years ago

Update the windows packaging file for Thunderbird.

Categories

(Thunderbird :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Now that we have package-compare running on the tinderboxes, we can easily see there are some files missing from the windows installer/zip file.

Patch attached to start fixing this. Some notes:

- installed-chrome.txt isn't required, just an artefact of us still building in mozilla/extensions/wallet
- appstartup.xpt and widget.xpt were in the file twice
- mailnews.xpt was removed by bug 451988
- I've not touched the bin/res stuff, we seem to be excluding some of it in mail/installer/Makefile.in and it probably needs some more investigation as to why.
Attachment #336327 - Flags: review?(philringnalda)
Flags: wanted-thunderbird3+
Attachment #336327 - Flags: review?(philringnalda) → review+
Comment on attachment 336327 [details] [diff] [review]
[checked in] Sort out packages file.

Checked in, changeset id: 245:b2eb4a5e6703

This has definitely improved the situation, there's a couple of things still missing, I'll deal with them in a few days.
Attachment #336327 - Attachment description: Sort out packages file. → [checked in] Sort out packages file.
Target Milestone: Thunderbird 3.0a3 → Thunderbird 3.0b1
-> b2
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Attached patch The rest, v.1Splinter Review
Borrowing this bug, since I need the decisions made to do unix/packages-static

From a tinderbox build log's packages-compare from last night:

--- ../../mozilla/dist/pack-list.txt	Sat Dec 13 21:41:52 2008
+++ ../../mozilla/dist/bin-list.txt	Sat Dec 13 21:41:52 2008
+bin/IA2Marshal.dll

Intentionally not packaged, it's an experimental thing for a11y developers.

+bin/components/cookie.xpt

Added; not packaging an xpt because we don't much like or use a thing is a sure path to breakage.

+bin/components/nsComposerCmdLineHandler.js

Not added, we really should fix the ifdef so we don't build it.

+bin/components/places.xpt

Added, we're building a teeny tiny places.xpt because of bug 251337, not packaging it doesn't seem like a good thing.

+bin/components/prefetch.xpt

Added, again, we don't much like it isn't a good reason to not package it.

+bin/components/walleteditor.xpt
+bin/components/walletpreview.xpt

Except when it comes to wallet-things :)

+bin/defaults/messenger/en-US/mailViews.dat

Bug 469569

+bin/defaults/profile/US/localstore.rdf
+bin/defaults/profile/US/mimeTypes.rdf

Apparently we hardly ever clobber the build machines - I killed those in bug 466211, almost a month ago.

+bin/defaults/wallet/DistinguishedSchema.tbl
+bin/defaults/wallet/FieldSchema.tbl
+bin/defaults/wallet/PositionalSchema.tbl
+bin/defaults/wallet/SchemaConcat.tbl
+bin/defaults/wallet/SchemaStrings.tbl
+bin/defaults/wallet/StateSchema.tbl
+bin/defaults/wallet/VcardSchema.tbl

So very much not added.

+bin/dependentlibs.list

Only of interest for embedders.

+bin/js-config
+bin/js.exe
+bin/js3250.lib

jsshell, intentionally not shipped, plus what seems to me like it throwing trash on the floor, though maybe it has to.

+bin/mangle.exe

Test program for shlibsign

+bin/plugins/npnul32.dll

Needs further investigation into whether shipping that 68KB to everyone will actually help the allow.plugins folks install missing plugins, so I'll farm it out to another bug.

+bin/regxpcom.exe

Nobody loves it, everybody NO_PKG_FILES it.

+bin/res/arrow.gif
+bin/res/arrowd.gif
+bin/res/broken-image.gif
+bin/res/contenteditable.css
+bin/res/designmode.css
+bin/res/html/folder.png
+bin/res/loading-image.gif

Added; things which cost almost nothing to package, and risk frustrating confusion (or, I'd think for loading-image.gif, that ugly red diamond) due to their absence. While we were not packaging loading-image.gif on all platforms (saving 122 bytes uncompressed), we were packaging broken-image.gif everywhere except Windows, where we saved an extra 106 bytes uncompressed by leaving it out.

+bin/shlibsign.exe
+bin/xpcshell.exe
+bin/xpidl.exe
+bin/xpt_dump.exe
+bin/xpt_link.exe

The big clot of unneeded NO_PKG_FILES things.
Attachment #352957 - Flags: review?(bugzilla)
Blocks: 420391
Blocks: 462712
Depends on: 469630
Attachment #352957 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/0609981c2ad7
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.