453135 - MozillaStageUpload should upload complete mars to latest

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

Bug 426443 made MozillaStageUpload upload complete MARs to dated dirs, and if both dated and latest are on, the syncCommand() copies them to latest as well. If dated is not on, we ignore MARs.

I'd like to get AUS working for SeaMonkey localized builds, just pointing to the newest full update all the time, so it would be nice to get complete MARs into latest even if we don't upload to dated.

Comment 1

[Robert Kaiser]

Attachment: also upload MARs for latest

This is the fairly easy patch that should do it (as said previously, when releaseToDated is True, syncCommand() takes care of also copying the MAR(s) to latestDir.

Comment 2

[Robert Kaiser]

Comment on attachment 336353 [details] [diff] [review]
also upload MARs for latest

Forward to Nick as Ben is too busy currently.

Comment 3

[Robert Kaiser]

Comment on attachment 336353 [details] [diff] [review]
also upload MARs for latest

>Index: steps/transfer.py
>===================================================================
>@@ -270,14 +270,16 @@ class MozillaStageUpload(ShellCommand):
>             if self.releaseToDated:
>                 cmd += self.syncCommand(datedDir, latestDir) + " && "
>             else:
>                 cmd += self.uploadCommand(latestDir) + " && "
>             cmd += self.chmodCommand(latestDir)
>             if self.group:
>                 cmd += " && " + self.chgrpCommand(latestDir)
>+                if self.uploadCompleteMar:
>+                    cmd += self.uploadCompleteMarCommand(latestDir) + " && "
>             commands.append(cmd)

Sorry, this is at the wrong place, should be in the |else:| above, but the lines themselves are correct.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 336353 [details] [diff] [review]
also upload MARs for latest

r+, although it's obviously nicer to see the actual patch.

We should also fix the |if self.releaseToDated:| block to move the chmod after the mar upload.

Comment 5

[Robert Kaiser]

Attachment: final patch, as checked in

This is the version I checked in, nits fixed.

Comment 6

[Robert Kaiser]

Marking FIXED, I promise the next such patch (and I have one more upcoming) will be the actual one that works :)