Closed
Bug 453177
Opened 16 years ago
Closed 16 years ago
Move moz_places.user_title removal back to MigrateV6Up
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file)
|
15.18 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Somewhere along the line, the code to remove moz_places.user_title (obsoleted in bug 371800) got placed in nsNavHistory::CleanUpOnQuit from nsNavHistory::MigrateV6Up (added in bug 319455). I cannot seem to find the specific changeset that caused this, but there's no reason to check for this on every shutdown - it really is part of the migration. Extra work on shutdown makes me sad :(
|
Assignee | |
Comment 1•16 years ago
|
||
We actually do a whole lot of stuff on shutdown; stuff that all seems like it should be in migration code. I'll likely file more bugs once I do more research.
|
|
Assignee | |
Updated•16 years ago
|
Summary: Fix migration code in MigrateV6Up → Move moz_places.user_title removal back to MigrateV6Up
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #336948 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs review dietrich]
|
||
Comment 3•16 years ago
|
||
Comment on attachment 336948 [details] [diff] [review] v1.0 r=me
Attachment #336948 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [has patch][needs review dietrich] → [has patch][has review]
|
|
Assignee | |
Comment 4•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/70c80842c67a
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in
before you can comment on or make changes to this bug.
Description
•