453178 - Reduce shutdown work in places

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

We do a lot of stuff that we shouldn't really be doing - let's put it in the proper place...

Comment 1

[Marco Bonardo [:mak]]

further changes will need refactoring part of expiration, so what we could do for 3.1 has been done. Other enhancements should be found for 3.2

Comment 2

[Marco Bonardo [:mak]]

I was thinking ideally backup should be a fire and forget task. Actually bookmarks backup is done on 1 hour idle or on shutdown if idle did not find a good slot, and i think it takes up much time (especially for users with a lot of bookmarks).
Due to the high idle time, i think vast majority of users will have to do backup on shutdown. There's no reason for backup to wait for anything, ideally it should be done in a background worker thread, without any need for idle timers, nor shutdown, the main issue is that resultNodes are not threadsafe.

In the short term (3.1?) we could try reducing the idle time from 1 hour to 15 minutes, so it's less probable that the backup could happen on shutdown.

This would hwv only speed up the first shutdown of every day since we have a maximum of 1 backup per day.

Comment 3

[Marco Bonardo [:mak]]

a bunch of work has been done here, all dependencies are fixed, new ideas will get their own bugs, but looks like we don't need this meta anymore.