this is a recent regression. STR: 1. create a new profile 2. open the bookmarks menu and drag "Get bookmarks add-ons" between the two smart bookmarks (recently bookmarked and recent tags) result: 3. the bookmark is inserted at the top expected: 3. bookmarks is correctly inserted between smart bookmarks regression range: 20080827031643 - 20080828034823 needs stricter range (hourly)
probably regression from bug 356295, needs to be verified, cc-ing neil
so it's a target problem, we were using event.layerY, the new impl does not support it
Created attachment 336491 [details] [diff] [review] support layerX/layerY for drag and popup events
another thing, we were doing aEvent.originalTarget.getAttribute("anonid") to see if we were over "scrollbutton-up" of the arrow scrollbox, now it's not working, i can't get the arrow button as originalTarget anymore
(In reply to comment #4) > another thing, we were doing aEvent.originalTarget.getAttribute("anonid") to > see if we were over "scrollbutton-up" of the arrow scrollbox, now it's not > working, i can't get the arrow button as originalTarget anymore Do you have a testcase here? 'originalTarget' seems to be working for me.
i don't have a test case yet, however if you dragover the scroll arrows in a places menu (the bookmarks menu for example) it should scroll. in menu.xml ondragover we do var anonid = aEvent.originalTarget.getAttribute("anonid"); this was working before, not working now
target is probably the element behind the scroll button instead of the button itself
mh, i've created a test and i see that it's working, so don't worry, layerY support is enough
I won't be able to check this in for a few days.
Summary: drag and drop is wrong in the bookmarks menu → drag and drop has wrong target in places menupopups (event.layerY support missing)
Thank you Neil http://hg.mozilla.org/mozilla-central/rev/0596ac47428f
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
verified fixed with hourly build: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080903113031 Minefield/3.1b1pre Firefox/3.0 ID:20080903113031
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.