[RFE] Pass the current locale as argument to test function on filter.py

RESOLVED INVALID

Status

Mozilla Localizations
Infrastructure
--
enhancement
RESOLVED INVALID
9 years ago
3 years ago

People

(Reporter: Caio Tiago Oliveira (asrail), Assigned: Caio Tiago Oliveira (asrail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 336429 [details] [diff] [review]
Proposed patch

SeaMonkey depends on venkman and chatzilla to make a fully localized build.
Since not all of the locales have venkman or chatzilla translated, the all-locales for SeaMonkey is different from venkman and chatzilla.

To make it possible to check for venkman and chatzilla strings only when they're present on its own all-locales, the SeaMonkey's "test" function on filter.py have to know about the current locale.

The patch for compare-locales is trivial. The down side is that every filter.py around would have to be altered to add new parameter. Even though this change is also trivial.

There is an use case attached to bug 403993.
Attachment #336429 - Flags: review?(l10n)

Comment 1

9 years ago
Is this still needed?

Updated

9 years ago
Attachment #336429 - Flags: review?(l10n) → review-

Comment 2

9 years ago
Comment on attachment 336429 [details] [diff] [review]
Proposed patch

r-, as this doesn't seem to be needed. Rerequest if the need comes up again.
(Assignee)

Comment 3

3 years ago
The solution to bug 403993 made this bug invalid.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.