453255 - Use clickSelectsAll in search fields

Status: NEW

(Firefox :: General, enhancement)

Description

[Nochum Sossonko [:Natch]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

Spin-off of bug 317419 for Seamonkey, this one's for Firefox.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Nochum Sossonko [:Natch]]

Attachment: Firefox complete patch (toolkit/browser)

This is all for firefox, as requested I put it in a separate bug, the Seamonkey stuff I'll put in the other bug.

Comment 2

[Nochum Sossonko [:Natch]]

Comment on attachment 336441 [details] [diff] [review]
Firefox complete patch (toolkit/browser)

gotta update, new patch coming

Comment 3

[Nochum Sossonko [:Natch]]

Attachment: Updated to HEAD

Changes to Browser and Toolkit.

Comment 4

[Nochum Sossonko [:Natch]]

gavin: is firefox interested in taking this at all?

Comment 5

[Nochum Sossonko [:Natch]]

Comment on attachment 337547 [details] [diff] [review]
Updated to HEAD

-                   oncommand="doFind();"/>
+                   oncommand="doFind(); clickSelectsAll="true"/>

Not good! :( . I'll redo this if this interests anyone. :)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Sorry I didn't comment earlier, thought I had... I'm not sure I understand the rationale behind adding clickSelectsAll to these. clickSelectsAll makes it easier if you're frequently entering new text as opposed to editing existing text (e.g. URL bar and search bar), and I'm not sure if that's the case for each of the textboxes being changed here. I guess I don't feel strongly either way - perhaps someone on the UX team does? :)

Comment 7

[Nochum Sossonko [:Natch]]

-> default owner

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #6)
> each of the textboxes being changed here. I guess I don't feel strongly either
> way - perhaps someone on the UX team does? :)

Alex, what is your position here?

Comment 9

[Nochum Sossonko [:Natch]]

Would be nice to get some input from UX here, I believe this is wontfix...

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

>I'm not sure if that's the case for each of the textboxes being changed here.

What are the other search text boxes in play here, thinks like find bar, about:config, and the applications prefpane?  For those three the last two should be clicksSelectAll, but not the find bar (where users are more likely to tweak the existing text).  I don't care about the default behavior, but we should ideally give some thought to each instance of the search field to make sure we are making the right call on the probability of new text versus tweaking.

Comment 11

[Nochum Sossonko [:Natch]]

Thanks Alex! To sum-up, I imagine any patch would have to go through ui-review to ensure the correct attributes are applied to the proper fields.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

perhaps generally speaking search fields tend to get new information, so we should default to clickSelectsAll?  Kind of hard to say for sure in the abstract.  Either way we should give each field some thought.

Comment 13

[Mark Capella [:capella]]

Given the age of this bug, would it make sense to mark this wontfix, and address any encountered future cases as specific / targeted issues?