453343 - Provide better error message for the stack-only checker

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Attachment: Better stack-checker errors, rev. 1

The current stack-only checker gives you the location of the call to "operator new" and the type of the thing being created, but it doesn't tell you why that thing isn't allowed on the stack. In many cases, it's a complicated reason such as "it inherits from class Y, which has member Y::mFoo which inherits from Bar which has member Bar::mFoo which is of type nsAutoString which is marked NS_STACK_CLASS". This patch provides all that information in a form that emacs compile mode can link you to each location along the way.

Comment 1

[David Mandelin [:dmandelin]]

Comment on attachment 336522 [details] [diff] [review]
Better stack-checker errors, rev. 1

Very nice. Historically a lot of static checkers have fallen down on error message usability. I like the string-format module too, I've wanted that.

Comment 2

[Benjamin Smedberg]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/53f922f0a153