453362 - "Firefox Start" import text causes horizontal scrollbars

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

The first radio-button string after choosing Microsoft Internet Explorer in the migration dialog for es-ES causes horizontal scrollbars.

Happens in both 2.0.0.x builds, such as: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.8.1.17) Gecko/2008082909 Firefox/2.0.0.17, and trunk.

NOTE: I'm not blaming the text: just as with the Major Update dialog, we probably want to try to take a fix for 3.1 to allow for slightly longer strings; not sure how the translated text could be shortened and still convey the full meaning.

Screenshot to follow.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

Adding es-ES Firefox owner

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Ok, simple, the title says: "Por favor, seleccione le página de inicio que desea usar"

And the selection: "Firefox Start, una página rápida de inicio con buscador incorporado".

So, if "página ... de inicio" is twice, we can omit the second one and the string will be shorter.

Ricardo, Nukeador, ideas?

Comment 4

[Rubén Martín [:Nukeador] ❌ [away till Aug 31st]]

(In reply to comment #3)
> Ok, simple, the title says: "Por favor, seleccione le página de inicio que
> desea usar"
> 
> And the selection: "Firefox Start, una página rápida de inicio con buscador
> incorporado".
> 
> So, if "página ... de inicio" is twice, we can omit the second one and the
> string will be shorter.
> 
> Ricardo, Nukeador, ideas?

So, you suggestion is:

"Firefox Start, una página rápida con buscador incorporado"

It seems ok to me.

Comment 5

[Guillermo López :willyaranda (probably SLOW response)]

Yes, exactly. I will wait for Ricardo's comment to change to that on hg.

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #5)
> Yes, exactly. I will wait for Ricardo's comment to change to that on hg.

I suggest "Firefox Start, una página ligera con buscador incluido". The "rápida" translation is something that probably isn't fully capturing the original sense of the en-US phrase. And "incluido" is shorter than "incorporado" (less and narrower letters). This is just a suggestion, the proposed solution in comments #3 and #4 are as valid as mine.

Anyway, this is a one-language solution. If es-ES is the only localization affected, then changing the string is the way to go (and we should probably move this bug Mozilla Localizations -> es-ES, but if there are more localizations affected, then it is a i18n problem, I'd say, and a global solution making the dialog width a localizable property would be better).

From a search in MXR, I'd say that other language may be also affected (for instance, mk):

http://mxr.mozilla.org/l10n-central/search?string=homePageSingleStartMain

Comment 7

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for trunk

Choosing Ricardo's option. Patch that will land on hg.

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

http://hg.mozilla.org/l10n-central/es-ES/rev/8d4a410a4e88

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I can tell just from the committed patch that this will probably fix the issue; is there a way I can get a localized build to verify?

Thanks for fixing!

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/

Please, download the Windows build and tell us the final results.

Thanks a lot!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #10)
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/
> 
> Please, download the Windows build and tell us the final results.
> 
> Thanks a lot!

I can't get that migration window to come up with the nightly builds, presumably because, since they're not officially branded builds, they don't have the start-page migration code path.

I think in good faith you can mark this fixed, based on the new shorter string length, though.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 (wow, old bug).