Declare PR_ImportTCPSocket in a public header file

RESOLVED FIXED in 4.7.2

Status

NSPR
NSPR
P1
enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Christophe Ravel)

Tracking

4.7.2
Sun
OpenSolaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Lots of software uses PR_ImportTCPSocket.  The LDAP SDK source in Mozilla's
repository uses it.  But PR_ImportTCPSocket is not declared in any public
header file.  It's time to publicly declare it.  It's to nobody's benefit
for it to remain private, IMO.

Comment 1

10 years ago
I explained this issue to Christophe the other day.
This is a Sun packaging issue:
http://mxr.mozilla.org/nspr/source/nsprpub/pkg/solaris/SUNWprd/prototype

It should export these headers:
obsolete/pralarm.h
obsolete/probslet.h
obsolete/prsem.h
private/pprio.h
private/pprthred.h
private/prpriv.h

"obsolete" indicates that the headers declare deprecated functions.

"private" indicates the headers declare functions that depend on
the internals of the current NSPR implementation, which is unlikely
to change because of our strong backward compatibility guarantee.

Comment 2

10 years ago
As an example, here is how Mozilla packages NSPR in a SDK:
http://mxr.mozilla.org/mozilla-central/source/xpcom/build/xpcom.pkg#32

You should export all the headers installed in the
mozilla/dist/xxx.OBJ/include directory during the build.

Uses of "private/pprio.h" in Mozilla code:
http://mxr.mozilla.org/mozilla-central/search?string=pprio.h

Updated

10 years ago
Blocks: 452908

Comment 3

10 years ago
When can we expect this bug to get fixed?
(Reporter)

Comment 4

10 years ago
Christophe, 
I think you control the files that package NSPR for OpenSolaris.
I'm assigning this bug to you.
Assignee: wtc → christophe.ravel.bugs
OS: All → OpenSolaris
Hardware: All → Sun

Comment 5

10 years ago
Can we get this bug (adding private directory and missing files in obsolete directory) fixed asap? It would be nice to get it done before 2008.11 build for OpenSolaris. I expect a lot of customers will start using this 2008.11 build.
(Reporter)

Comment 6

10 years ago
Meena, I suggest you write directly to Christophe.
(Assignee)

Comment 7

10 years ago
Created attachment 343967 [details] [diff] [review]
Add the 6 missing files to the Solaris and Linux packages
Attachment #343967 - Flags: review?(wtc)
(Assignee)

Updated

10 years ago
Priority: -- → P1
Target Milestone: --- → 4.7.2

Comment 8

10 years ago
Comment on attachment 343967 [details] [diff] [review]
Add the 6 missing files to the Solaris and Linux packages

r=wtc, if you don't export private/primpl.h and private/pprmwait.h.

Not all the headers in mozilla/nsprpub/pr/include/private should be exported.
Attachment #343967 - Flags: review?(wtc) → review+
(Assignee)

Comment 9

10 years ago
I am just adding to the package the ones that are exported:
private/pprio.h
private/pprthred.h
private/prpriv.h

as defined in comment #1.

Committed on NSPR trunk:
Checking in linux/Makefile.in;
/cvsroot/mozilla/nsprpub/pkg/linux/Makefile.in,v  <--  Makefile.in
new revision: 1.11; previous revision: 1.10
done
Checking in solaris/SUNWprd/prototype;
/cvsroot/mozilla/nsprpub/pkg/solaris/SUNWprd/prototype,v  <--  prototype
new revision: 1.5; previous revision: 1.4
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.