Lots of software uses PR_ImportTCPSocket. The LDAP SDK source in Mozilla's repository uses it. But PR_ImportTCPSocket is not declared in any public header file. It's time to publicly declare it. It's to nobody's benefit for it to remain private, IMO.
I explained this issue to Christophe the other day. This is a Sun packaging issue: http://mxr.mozilla.org/nspr/source/nsprpub/pkg/solaris/SUNWprd/prototype It should export these headers: obsolete/pralarm.h obsolete/probslet.h obsolete/prsem.h private/pprio.h private/pprthred.h private/prpriv.h "obsolete" indicates that the headers declare deprecated functions. "private" indicates the headers declare functions that depend on the internals of the current NSPR implementation, which is unlikely to change because of our strong backward compatibility guarantee.
As an example, here is how Mozilla packages NSPR in a SDK: http://mxr.mozilla.org/mozilla-central/source/xpcom/build/xpcom.pkg#32 You should export all the headers installed in the mozilla/dist/xxx.OBJ/include directory during the build. Uses of "private/pprio.h" in Mozilla code: http://mxr.mozilla.org/mozilla-central/search?string=pprio.h
When can we expect this bug to get fixed?
Christophe, I think you control the files that package NSPR for OpenSolaris. I'm assigning this bug to you.
Assignee: wtc → christophe.ravel.bugs
OS: All → OpenSolaris
Hardware: All → Sun
Can we get this bug (adding private directory and missing files in obsolete directory) fixed asap? It would be nice to get it done before 2008.11 build for OpenSolaris. I expect a lot of customers will start using this 2008.11 build.
Meena, I suggest you write directly to Christophe.
Created attachment 343967 [details] [diff] [review] Add the 6 missing files to the Solaris and Linux packages
Attachment #343967 - Flags: review?(wtc)
Comment on attachment 343967 [details] [diff] [review] Add the 6 missing files to the Solaris and Linux packages r=wtc, if you don't export private/primpl.h and private/pprmwait.h. Not all the headers in mozilla/nsprpub/pr/include/private should be exported.
Attachment #343967 - Flags: review?(wtc) → review+
I am just adding to the package the ones that are exported: private/pprio.h private/pprthred.h private/prpriv.h as defined in comment #1. Committed on NSPR trunk: Checking in linux/Makefile.in; /cvsroot/mozilla/nsprpub/pkg/linux/Makefile.in,v <-- Makefile.in new revision: 1.11; previous revision: 1.10 done Checking in solaris/SUNWprd/prototype; /cvsroot/mozilla/nsprpub/pkg/solaris/SUNWprd/prototype,v <-- prototype new revision: 1.5; previous revision: 1.4 done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.