Closed Bug 45341 Opened 26 years ago Closed 25 years ago

make sure all menu/tree/button icons are of equal heights

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla0.9

People

(Reporter: jrgmorrison, Assigned: hewitt)

References

()

Details

Overview Description: The image at chrome://communicator/skin/bookmarks/iefavorite.gif in either the modern or classic skin is 16px high. The standard bookmark icon is 12px in the rest of these skins. With a change that hyatt made to the tree code, in the interest of performance, all tree rows must be the same height. These two things combined mean that the bookmark manager application now has too great a line-height: for its rows. (In the case of a long bookmark list, the app will start with a ~12px line-height:, but once the IE Favorites is scrolled into view, all rows will be converted to have ~16px line-height:). I realize that you (slamm) don't design the icons, but I'm not sure where to start this bug, so starting it with bookmarks. Re-assign as required. Steps to Reproduce: 1) Open the bookmarks manager on win32, and note that the rows are taller than most of them need to be. (Or if not apparent when opened, scroll down to the IE Favorites, or force open the twisty on the IE Favorites folder -- all row heights will be changed after that). Build Date & Platform Bug Found: 2000071215 win95 2000071208 mac
All icons (in all skins) **used in trees** need to be 16px high/wide, not 12px. For example, this is partially due to search branding icons (which could be aggregated into bookmarks) which are always 16px. Bumping this bug over to Ben so that he can ensure that any 12px icons can be changed to be 16px, so that trees don't act funky.
Assignee: slamm → ben
Netscape Nav triage team: this is not a Netscape beta stopper. reassigning to hangas to verify
Assignee: ben → hangas
Keywords: nsbeta1-
I disagree. To borrow rjc's words "All icons (in all skins) **used in trees** need to be 16px high/wide, not 12px.". This is not simply a visual "look" thing. The tree widget will size all rows to the height of the tallest row visible. If, at a later time, one of those rows changes size (due to a different sized icon for example), then all the rows in the tree will be resized to that new maximum height. We specifically hard coded some row heights for the directory.xul at the last moment to improve the ftp viewer, because the spinning icon had a different height than the other icons (which would cause the entire ftp tree to change row heights when the spinner kicked in). Let's fix these icons in this next release cycle.
Keywords: nsbeta1- → nsbeta1
OS: Windows 95 → All
Hardware: PC → All
Sending to Joe
Assignee: hangas → hewitt
We don't even use the iefavorite.gif image anymore, marking invalid. That image will be removed soon.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
The question pending was really a little broader than iefavorite.gif. If all icons used in trees have a consistent height, then close this again.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Marking nsbeta1+
Keywords: nsbeta1 → nsbeta1+
Target Milestone: --- → mozilla0.9
Status: REOPENED → ASSIGNED
Summary: iefavorite.gif is 16px high; forces *all* rows to have this height → make sure all menu/tree/button icons are of equal heights
fixed with the 65745 checkin
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
QA Contact: claudius → jrgm
john, I'm bouncing this back over to you b/c I don't know what to do with it. The bookmarks case was obsoleted by the removal of the iefavorites.gif, and so have the ftp directories for the time being. So I leave it to you to scout around for 12/16px icons in trees :-)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.