453542 - Use a faster strategy for unified toolbar drawing

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Drawing a window's titlebar and toolbar works like this:
 - The titlebar is drawn by the window's background texture which applies to
   the whole window.
 - The toolbar is drawn by nsNativeThemeCocoa::DrawUnifiedToolbar into the
   content view.

It would be more efficient to make the content view and the toolbar transparent and to draw both the titlebar and the toolbar gradient in the window's background texture.
Then we wouldn't even have to set a custom window background color on Leopard.

Comment 1

[Markus Stange [:mstange]]

This won't work. We only know the height of the toolbar when we're painting it, at which point the window background has already been painted. So when we're painting the toolbar and noticed that its height has changed, we would need to paint the window background again, and since the toolbar sits on top of it, also the toolbar... there's no gain there.