Closed
Bug 453698
Opened 16 years ago
Closed 16 years ago
nsAbLDAPCard::SetMetaProperties assumes an entry has at least one objectClass
Categories
(MailNews Core :: LDAP Integration, defect)
MailNews Core
LDAP Integration
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: pi, Assigned: pi)
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
standard8
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Thunderbird 3 doesn't display any search results for queries sent to my school's (Michigan Tech's) LDAP server when bound anonymously. It looks like the problem is that the result entries don't have an objectClass, and nsAbLDAPCard::SetMetaProperties [1] assumes that every entry has at least one object class (see lines 307-310 [2]). The attached patch just clears m_objectClass earlier and returns NS_OK if rv is LDAP_DECODING_ERROR after trying to get the objectClass values, which is returned if the attribute isn't present. [1] http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/src/nsAbLDAPCard.cpp#280 [2] http://mxr.mozilla.org/comm-central/source/mailnews/addrbook/src/nsAbLDAPCard.cpp#307
Attachment #336906 -
Flags: review?(bugzilla)
|
Assignee | |
Updated•16 years ago
|
Attachment #336906 -
Flags: superreview?(bienvenu)
|
||
Updated•16 years ago
|
Attachment #336906 -
Flags: review?(bugzilla) → review+
|
|
||
Comment 1•16 years ago
|
||
I think it helps to cc David on bugs he's got review requests for.
|
||
Updated•16 years ago
|
Attachment #336906 -
Flags: superreview?(bienvenu) → superreview+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 336906 [details] [diff] [review] Patch sorry for the delay;
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•16 years ago
|
||
Checked in, changeset id: 315:c58a10a0b262
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•