Closed
Bug 453759
Opened 13 years ago
Closed 13 years ago
update media queries implementation to match recent spec changes
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b1
People
(Reporter: dbaron, Assigned: dbaron)
References
()
Details
(Keywords: css3, verified1.9.1)
Attachments
(4 files)
6.60 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
10.70 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
3.21 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
3.00 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
I have three patches to update the media queries implementation to match recent spec clarifications / changes, now reflected in http://dev.w3.org/csswg/css3-mediaqueries/ . The patch headers point to the URL of the messages involved. However, the third patch exposed an additional bug that I haven't had a chance to debug yet. The first and third patches are for issues that I knew were ambiguous so I intentionally left tests marked todo to remind me of them. The three patches apply on top of each other. (They may or may not apply independently.)
Flags: blocking1.9.1?
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
This seems to have exposed another bug about dynamic changes when one dimension is zero.
Assignee | ||
Updated•13 years ago
|
Attachment #336969 -
Attachment description: make min-* and max-* expressions with no values into parse errors → patch 2: make min-* and max-* expressions with no values into parse errors
Assignee | ||
Comment 4•13 years ago
|
||
And I see the same three failures on Windows as on Linux, so it doesn't seem to be a platform-specific bug.
Assignee | ||
Comment 5•13 years ago
|
||
This fixes the test failures that are now visible following patch 3.
Attachment #337093 -
Flags: superreview?(roc)
Attachment #337093 -
Flags: review?(roc)
Assignee | ||
Updated•13 years ago
|
Attachment #336968 -
Flags: superreview?(bzbarsky)
Attachment #336968 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•13 years ago
|
Attachment #336969 -
Flags: superreview?(bzbarsky)
Attachment #336969 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•13 years ago
|
Attachment #336970 -
Flags: superreview?(bzbarsky)
Attachment #336970 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•13 years ago
|
Blocks: mediaqueries
![]() |
||
Updated•13 years ago
|
Attachment #336968 -
Flags: superreview?(bzbarsky)
Attachment #336968 -
Flags: superreview+
Attachment #336968 -
Flags: review?(bzbarsky)
Attachment #336968 -
Flags: review+
![]() |
||
Comment 6•13 years ago
|
||
Comment on attachment 336968 [details] [diff] [review] patch 1: stricter rules for parsing of grid feature r+sr=bzbarsky
![]() |
||
Comment 7•13 years ago
|
||
Comment on attachment 336969 [details] [diff] [review] patch 2: make min-* and max-* expressions with no values into parse errors r+sr=bzbarsky
Attachment #336969 -
Flags: superreview?(bzbarsky)
Attachment #336969 -
Flags: superreview+
Attachment #336969 -
Flags: review?(bzbarsky)
Attachment #336969 -
Flags: review+
![]() |
||
Updated•13 years ago
|
Attachment #336970 -
Flags: superreview?(bzbarsky)
Attachment #336970 -
Flags: superreview+
Attachment #336970 -
Flags: review?(bzbarsky)
Attachment #336970 -
Flags: review+
Assignee | ||
Comment 8•13 years ago
|
||
I landed patches 1, 2, and 3: http://hg.mozilla.org/mozilla-central/rev/df134eac2ff1 http://hg.mozilla.org/mozilla-central/rev/580343716b2d http://hg.mozilla.org/mozilla-central/rev/5cb6b3b6af82
Attachment #337093 -
Flags: superreview?(roc)
Attachment #337093 -
Flags: superreview+
Attachment #337093 -
Flags: review?(roc)
Attachment #337093 -
Flags: review+
Assignee | ||
Comment 9•13 years ago
|
||
Landed patch 4: http://hg.mozilla.org/mozilla-central/rev/d2ac7638c63a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: blocking1.9.1? → blocking1.9.1+
Keywords: fixed1.9.1
Comment 10•12 years ago
|
||
Patches include test cases and seeing as there hasn't been any discussions about this bug for 8 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
You need to log in
before you can comment on or make changes to this bug.
Description
•