453759 - update media queries implementation to match recent spec changes

Status: VERIFIED FIXED

Description

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

I have three patches to update the media queries implementation to match recent spec clarifications / changes, now reflected in http://dev.w3.org/csswg/css3-mediaqueries/ .  The patch headers point to the URL of the messages involved.

However, the third patch exposed an additional bug that I haven't had a chance to debug yet.

The first and third patches are for issues that I knew were ambiguous so I intentionally left tests marked todo to remind me of them.

The three patches apply on top of each other.  (They may or may not apply independently.)

Comment 1

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Created attachment 336968 [details] [diff] [review]
patch 1: stricter rules for parsing of grid feature

Comment 2

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Created attachment 336969 [details] [diff] [review]
patch 2: make min-* and max-* expressions with no values into parse errors

Comment 3

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Created attachment 336970 [details] [diff] [review]
patch 3: make valueless expressions false when the device's value is the zero length

This seems to have exposed another bug about dynamic changes when one dimension is zero.

Comment 4

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

And I see the same three failures on Windows as on Linux, so it doesn't seem to be a platform-specific bug.

Comment 5

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Created attachment 337093 [details] [diff] [review]
patch 4: handle resizes even when one dimension is already zero

This fixes the test failures that are now visible following patch 3.

Comment 6

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 336968 [details] [diff] [review]
patch 1: stricter rules for parsing of grid feature

r+sr=bzbarsky

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 336969 [details] [diff] [review]
patch 2: make min-* and max-* expressions with no values into parse errors

r+sr=bzbarsky

Comment 8

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

I landed patches 1, 2, and 3:
http://hg.mozilla.org/mozilla-central/rev/df134eac2ff1
http://hg.mozilla.org/mozilla-central/rev/580343716b2d
http://hg.mozilla.org/mozilla-central/rev/5cb6b3b6af82

Comment 9

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8 (away December 22 - January 13) (if account gets disabled due to email bounces, ask a bugzilla admin to reenable it)]

Landed patch 4: http://hg.mozilla.org/mozilla-central/rev/d2ac7638c63a

Comment 10

[Aakash Desai [:aakashd]]

Patches include test cases  and seeing as there hasn't been any discussions about this bug for 8 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.