update media queries implementation to match recent spec changes

VERIFIED FIXED in mozilla1.9.1b1

Status

()

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({css3, verified1.9.1})

Trunk
mozilla1.9.1b1
css3, verified1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments)

I have three patches to update the media queries implementation to match recent spec clarifications / changes, now reflected in http://dev.w3.org/csswg/css3-mediaqueries/ .  The patch headers point to the URL of the messages involved.

However, the third patch exposed an additional bug that I haven't had a chance to debug yet.

The first and third patches are for issues that I knew were ambiguous so I intentionally left tests marked todo to remind me of them.

The three patches apply on top of each other.  (They may or may not apply independently.)
Flags: blocking1.9.1?
Created attachment 336970 [details] [diff] [review]
patch 3: make valueless expressions false when the device's value is the zero length

This seems to have exposed another bug about dynamic changes when one dimension is zero.
Attachment #336969 - Attachment description: make min-* and max-* expressions with no values into parse errors → patch 2: make min-* and max-* expressions with no values into parse errors
And I see the same three failures on Windows as on Linux, so it doesn't seem to be a platform-specific bug.
Created attachment 337093 [details] [diff] [review]
patch 4: handle resizes even when one dimension is already zero

This fixes the test failures that are now visible following patch 3.
Attachment #337093 - Flags: superreview?(roc)
Attachment #337093 - Flags: review?(roc)
Attachment #336968 - Flags: superreview?(bzbarsky)
Attachment #336968 - Flags: superreview+
Attachment #336968 - Flags: review?(bzbarsky)
Attachment #336968 - Flags: review+
Comment on attachment 336968 [details] [diff] [review]
patch 1: stricter rules for parsing of grid feature

r+sr=bzbarsky
Comment on attachment 336969 [details] [diff] [review]
patch 2: make min-* and max-* expressions with no values into parse errors

r+sr=bzbarsky
Attachment #336969 - Flags: superreview?(bzbarsky)
Attachment #336969 - Flags: superreview+
Attachment #336969 - Flags: review?(bzbarsky)
Attachment #336969 - Flags: review+
Attachment #336970 - Flags: superreview?(bzbarsky)
Attachment #336970 - Flags: superreview+
Attachment #336970 - Flags: review?(bzbarsky)
Attachment #336970 - Flags: review+
Attachment #337093 - Flags: superreview?(roc)
Attachment #337093 - Flags: superreview+
Attachment #337093 - Flags: review?(roc)
Attachment #337093 - Flags: review+
Flags: blocking1.9.1? → blocking1.9.1+
Patches include test cases  and seeing as there hasn't been any discussions about this bug for 8 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.