need a new basic sample plugin for Mac OS X

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

20.03 KB, application/octet-stream
Details
(Assignee)

Description

10 years ago
Our current basic sample plugin for Mac OS X is hopelessly out of date. It has a codewarrior build config and won't build, it has 68k mac support, it draws with quickdraw, and in many other ways it doesn't do what we recommend that plugin developers do. We need a new basic sample plugin for Mac OS X in our NPAPI SDK.
(Assignee)

Comment 1

10 years ago
Created attachment 337001 [details]
fix v0.5

This is a zip file containing a work-in-progress version of the new basic sample plugin for Mac OS X.

The new plugin draws with CoreGraphics, uses NP_GetEntryPoints instead of main to dish out function pointers, uses a plist file instead of a resource file for plugin info, and uses a modern Xcode project file to build. It is rewritten from scratch, it does not use the existing basic plugin sample's code. This new plugin also doesn't use the shared "common" code structure that exists in our SDK. The shared "common" code makes plugin samples more confusing for everyone, much better to just have each sample build on its own.

TODO: draw the UA string centered and wrapped, audit memory mgmt, and improve comments.
(Assignee)

Comment 2

10 years ago
Created attachment 337085 [details]
fix v1.0
Attachment #337085 - Flags: superreview?(jst)
(Assignee)

Comment 3

10 years ago
Right now the plugin has our normal tri-license, on checkin I'd like to make it BSD licensed so that anyone can use it as a starting point for a plugin.
(Assignee)

Comment 4

10 years ago
Created attachment 337096 [details]
fix v1.1

Includes BSD license and fixes a default include path.
Attachment #337001 - Attachment is obsolete: true
Attachment #337085 - Attachment is obsolete: true
Attachment #337096 - Flags: superreview?(jst)
Attachment #337085 - Flags: superreview?(jst)
(Assignee)

Comment 5

10 years ago
Created attachment 338056 [details]
fix v1.2

includes integer type fixes for new npapi header
Attachment #337096 - Attachment is obsolete: true
Attachment #338056 - Flags: superreview?(jst)
Attachment #337096 - Flags: superreview?(jst)

Updated

10 years ago
Attachment #338056 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 6

10 years ago
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 7

10 years ago
Hey Josh,

We're you still planning on splitting something out for windows?
(Assignee)

Comment 8

10 years ago
Yes but I am waiting for some other big changes to land. Some npapi header updates which will affect how sample plugins compile. Thanks for checking in!
QA Contact: ui → plugins
You need to log in before you can comment on or make changes to this bug.