Closed Bug 453831 Opened 13 years ago Closed 13 years ago

Focus in limbo after multi-tab launch pref set

Categories

(Firefox :: Session Restore, defect)

defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 3.1b1

People

(Reporter: aaronlev, Assigned: zeniko)

Details

(Keywords: access, fixed1.9.1, verified1.9.0.5)

Attachments

(1 file)

1. Under Tools->Options->Main-> Startup group box->When Firefox starts combobox:
Change to Show my windows and tabs from last time.
2. Load 2 simple pages (not Google which sets focus onload)
3. Exit and relaunch

Accessibility focus is now on the top level window, instead of the document.
Actually, it's not just accessibility focus. Focus in general is broken.

I can tell this because when even a single page is loaded with this pref set, arrows won't scroll (obvious using a long enough, scrollable page to test).
Summary: Incorrect focus events for multi-tab launch → Focus in limbo after multi-tab launch pref set
Component: Disability Access APIs → Session Restore
Product: Core → Firefox
QA Contact: accessibility-apis → session.restore
This confuses screen readers as well as messes up regular keyboard users.

I suspect it's a simple thing to fix. Something like: instead of focusing windows, focus documents.
Flags: blocking1.9.0.3?
Flags: blocking-firefox3.1?
It's indeed a one-line fix. Nice catch, Aaron.
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #337063 - Flags: review?(dietrich)
Attachment #337063 - Flags: review?(dietrich) → review+
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 3.1b1
http://hg.mozilla.org/mozilla-central/rev/b96ac5d9119a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 337063 [details] [diff] [review]
focus content instead of window

This is a simple fix which affects both screen reader access and regular keyboard access after launch.
Attachment #337063 - Flags: approval1.9.0.3?
Flags: blocking1.9.0.4?
Attachment #337063 - Flags: approval1.9.0.4? → approval1.9.0.4+
Comment on attachment 337063 [details] [diff] [review]
focus content instead of window

Approved for 1.9.0.4, a=dveditz for release-drivers
Comment on attachment 337063 [details] [diff] [review]
focus content instead of window

Didn't make 1.9.0.4. Nominating for 1.9.0.5. We'll revisit this soon.
Attachment #337063 - Flags: approval1.9.0.5?
Attachment #337063 - Flags: approval1.9.0.4-
Attachment #337063 - Flags: approval1.9.0.4+
Attachment #337063 - Flags: approval1.9.0.5? → approval1.9.0.5+
Comment on attachment 337063 [details] [diff] [review]
focus content instead of window

Approved for 1.9.0.5, a=dveditz for release-drivers

approved again, please get this checked in this time. The code freeze is a week away.
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Checking in browser/components/sessionstore/src/nsSessionStore.js;
new revision: 1.103; previous revision: 1.102
Keywords: fixed1.9.0.5
Verified for 1.9.0.5 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.5pre) Gecko/2008120105 GranParadiso/3.0.5pre. Focus is now properly set.
You need to log in before you can comment on or make changes to this bug.