Closed Bug 453841 Opened 11 years ago Closed 11 years ago

Remove unused strings in installer's custom.properties

Categories

(Thunderbird :: Installer, defect, minor)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: mcsmurf, Assigned: philor)

References

Details

Attachments

(1 file)

ERROR_CREATE_DIRECTORY is no longer used by any code, see http://mxr.mozilla.org/comm-central/search?string=ERROR_CREATE_DIRECTORY. It looks like it has been replaced by ERROR_CREATE_DIRECTORY_PREFIX and ERROR_CREATE_DIRECTORY_SUFFIX.
Oh and the comment under http://hg.mozilla.org/mozilla-central/annotate/69d14bce003f/toolkit/mozapps/installer/windows/nsis/common.nsh#l3818 should also be fixed, the comments for _PREFIX and _SUFFIX seem to be wrong.
I fixed the _SUFFIX comment in bug 454026 since it is Toolkit > NSIS Installer specific. Is the current _PREFIX comment wrong?
The _PREFIX comment is actually correct, I first thought _PREFIX_ERROR_CREATEDIR is used in another way.
The only instance of this string as far as NSIS is concerned is in Thunderbird's custom.properties file so over to Thunderbird's installer component.

note: the reference in Firefox's install.it locale file is for the old xpinstall installer.
Component: NSIS Installer → Installer
Product: Toolkit → Thunderbird
QA Contact: installer → installer
There's a bug somewhere where I'm supposed to remove install.it, isn't there? I should maybe do that.
Sorry, I haven't seen the bug to remove install.it anywhere but it should be safe to do. NSIS still uses charset.mk and will need that file until all installers use the unicode version of NSIS or MSI once that is fixed.
note: all of the strings in custom.properties should probably be checked to see if they are used.
Taking, but I think I'll skip bitrotting myself from bug 345386, since the other unused strings are the not-a-problem OPTION_COMPLETE_(DESC|RADIO) and WARN_APP_RUNNING_INSTALL, and the smack-in-my-context APP_DESC.
Assignee: nobody → philringnalda
Summary: Remove unused ERROR_CREATE_DIRECTORY string → Remove unused strings in installer's custom.properties
Depends on: 345386
Attached patch Fix v.1Splinter Review
I love the smell of deleted strings in the morning. Almost makes up for the UTF-8 fail of "@@ -93,14 +90,11 @@ STATUS_CLEANUP=Cleaning up the birdcage�"
Attachment #344015 - Flags: review?(bugzilla)
Attachment #344015 - Flags: review?(bugzilla) → review+
(In reply to comment #9)
> Created an attachment (id=344015) [details]
> Fix v.1
> 
> I love the smell of deleted strings in the morning. Almost makes up for the
> UTF-8 fail of "@@ -93,14 +90,11 @@ STATUS_CLEANUP=Cleaning up the birdcage�"
Thanks!

The UTF-8 fails are converted during the preprocessing of the locale files and left as is so when the installer can be built as unicode the strings don't have to change.
Comment on attachment 344015 [details] [diff] [review]
Fix v.1

oops... didn't mean to steal the review
Attachment #344015 - Flags: review?(bugzilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 3.0b1
http://hg.mozilla.org/comm-central/rev/018bcf2cee48
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.