453841 - Remove unused strings in installer's custom.properties

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

ERROR_CREATE_DIRECTORY is no longer used by any code, see http://mxr.mozilla.org/comm-central/search?string=ERROR_CREATE_DIRECTORY. It looks like it has been replaced by ERROR_CREATE_DIRECTORY_PREFIX and ERROR_CREATE_DIRECTORY_SUFFIX.

Comment 1

[Frank Wein [:mcsmurf]]

Oh and the comment under http://hg.mozilla.org/mozilla-central/annotate/69d14bce003f/toolkit/mozapps/installer/windows/nsis/common.nsh#l3818 should also be fixed, the comments for _PREFIX and _SUFFIX seem to be wrong.

Comment 2

[Robert Strong (they/them - no direct email)]

I fixed the _SUFFIX comment in bug 454026 since it is Toolkit > NSIS Installer specific. Is the current _PREFIX comment wrong?

Comment 3

[Frank Wein [:mcsmurf]]

The _PREFIX comment is actually correct, I first thought _PREFIX_ERROR_CREATEDIR is used in another way.

Comment 4

[Robert Strong (they/them - no direct email)]

The only instance of this string as far as NSIS is concerned is in Thunderbird's custom.properties file so over to Thunderbird's installer component.

note: the reference in Firefox's install.it locale file is for the old xpinstall installer.

Comment 5

[Phil Ringnalda (:philor)]

There's a bug somewhere where I'm supposed to remove install.it, isn't there? I should maybe do that.

Comment 6

[Robert Strong (they/them - no direct email)]

Sorry, I haven't seen the bug to remove install.it anywhere but it should be safe to do. NSIS still uses charset.mk and will need that file until all installers use the unicode version of NSIS or MSI once that is fixed.

Comment 7

[Robert Strong (they/them - no direct email)]

note: all of the strings in custom.properties should probably be checked to see if they are used.

Comment 8

[Phil Ringnalda (:philor)]

Taking, but I think I'll skip bitrotting myself from bug 345386, since the other unused strings are the not-a-problem OPTION_COMPLETE_(DESC|RADIO) and WARN_APP_RUNNING_INSTALL, and the smack-in-my-context APP_DESC.

Comment 9

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

I love the smell of deleted strings in the morning. Almost makes up for the UTF-8 fail of "@@ -93,14 +90,11 @@ STATUS_CLEANUP=Cleaning up the birdcage�"

Comment 10

[Robert Strong (they/them - no direct email)]

(In reply to comment #9)
> Created an attachment (id=344015) [details]
> Fix v.1
> 
> I love the smell of deleted strings in the morning. Almost makes up for the
> UTF-8 fail of "@@ -93,14 +90,11 @@ STATUS_CLEANUP=Cleaning up the birdcage�"
Thanks!

The UTF-8 fails are converted during the preprocessing of the locale files and left as is so when the installer can be built as unicode the strings don't have to change.

Comment 11

[Robert Strong (they/them - no direct email)]

Comment on attachment 344015 [details] [diff] [review]
Fix v.1

oops... didn't mean to steal the review

Comment 12

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/018bcf2cee48