Autocompleting from places doesn't work quite right yet.
Created attachment 337222 [details] [diff] [review] Proposed patch By bailing out early at the start of the search we can also simplify the search failed code.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #337222 - Flags: review?(ajschult)
Whoops, I forgot to explain the reason for this patch. Traditionally autocomplete datasources simply used to fail when passed an empty search string. However the Firefox designers had the bright idea to overload the search to produce their location bar history instead.
Created attachment 337239 [details] [diff] [review] Fix incremental results I discovered another bug - places tests the async code (it only ever returns results async) and in this case I wasn't clearing the counts with the results.
Attachment #337239 - Flags: review?(ajschult)
Pushed changeset 55504b35cd77 to mozilla-central. Pushed changeset 1d58ae237bdc to mozilla-central. KaiRo, do you have any other issues with places autocomplete?
From a small amount of preliminary testing today, the issues I saw seems to be fixed - thanks a lot!
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/1d8477b3472d Bail out early when the autocomplete field is empty r=ajschult https://hg.mozilla.org/comm-central/rev/e19a28d45911 Fix handling of partial autocomplete results r=ajschult
You need to log in before you can comment on or make changes to this bug.