454026 - Updates directory not removed on install on Vista

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

When Thunderbird is installed under program files app update creates the updates directory under %LOCALAPPDATA%\Thunderbird\<install dir name>\. We have code for removing this directory on install and uninstall but for some as of yet unknown reason the directory is not removed when installing... it is removed during uninstall. Also, this works with Firefox so I am filing under Thunderbird's Installer component vs. Toolkit's NSIS Installer component. I'll take a look at what's going on.

btw: the removal of this directory is a good thing to do in case an app update is downloaded / not applied and the user installs a different version of the app app update will try to update the newly installed version.

Comment 1

[Robert Strong (they/them - no direct email)]

This could also affect other apps so moving over to NSIS Installer

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1 - simplify the CleanUpdatesDir macro

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 337261 [details] [diff] [review]
patch rev1 - simplify the CleanUpdatesDir macro

Hey Jim, can I get you to take a look at this. It is much simpler to use the length of the $PROGRAMFILES etc. to figure out if $INSTDIR is under $PROGRAMFILES instead of looping through the individual characters.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 337261 [details] [diff] [review]
patch rev1 - simplify the CleanUpdatesDir macro

I'm going to add this simplification to the CleanVirtualStore macro

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 - simplify the CleanUpdatesDir and CleanVirtualStore macros

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3 - simplify the CleanUpdatesDir and CleanVirtualStore macros

Forgot to add the additional pop's for CleanVirtualStore

Comment 7

[Jim Mathies [:jimm]]

minor not in the comments - other than that, don't see any issues.

+ * $R6 = length of the long path to $PROGRAMFILES
+ * $R6 = length of the long path to $INSTDIR

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/dd9e757b2e96b028cb52ae6af8a744192693829f