Closed Bug 454090 Opened 12 years ago Closed 12 years ago

Use .trim() in search service

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.1b1

People

(Reporter: philor, Assigned: philor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Thanks to bug 305064, nsSearchService.js no longer needs to roll its own sTrim() function.

I saw as I was looking at what I was attaching that I made one logic change, from lowercase-then-trim to trim-then-lowercase, but I'd be rather surprised by any character that turns into a space when lowercased, and not lowercasing spaces ought to save several femtoseconds.
Attachment #337313 - Flags: review?(gavin.sharp)
Attachment #337313 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/d3342a3cc677
Blocks: 220348
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
You need to log in before you can comment on or make changes to this bug.