454109 - move urlbar functions to the urlbar binding

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch, the right one

Comment 2

[Asaf Romano (gone)]

Comment on attachment 337345 [details] [diff] [review]
patch, the right one


> 
> function toJavaScriptConsole()
> {
>   toOpenWindowByType("global:console", "chrome://global/content/console.xul");
> }
> 
> function BrowserDownloadsUI()
>@@ -4888,32 +4741,27 @@ function handleLinkClick(event, href, li
>       else
>         openNewWindowWith(href, doc, null, false);
>       event.stopPropagation();
>       return true;
>   }
>   return false;
> }
> 
>-function middleMousePaste(event)
>-{
>+function middleMousePaste(event) {

don't do that.


>   var postData = { };
>   url = getShortcutOrURI(url, postData);
>   if (!url)
>     return;
> 
>-  try {
>-    addToUrlbarHistory(url);
>-  } catch (ex) {
>-    // Things may go wrong when adding url to session history,
>-    // but don't let that interfere with the loading of the url.
>-  }
>+  addToUrlbarHistory(url);
>

I actually prefer that any exception may be caught here, so remove the other try block instead (and please reportErrror).


r=mano otherwise..

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/26a23e7f9449